Bug 1170954 - Fix mutex problems reported by coverity scan
Summary: Fix mutex problems reported by coverity scan
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: disperse
Version: 3.6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Xavi Hernandez
QA Contact:
URL:
Whiteboard:
Depends On: 1170254
Blocks: glusterfs-3.6.2
TreeView+ depends on / blocked
 
Reported: 2014-12-05 08:19 UTC by Xavi Hernandez
Modified: 2015-12-01 16:45 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1170254
Environment:
Last Closed: 2015-01-28 14:26:30 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Xavi Hernandez 2014-12-05 08:19:52 UTC
+++ This bug was initially created as a clone of Bug #1170254 +++

Description of problem:

Coverity scan reported 3 issues related to mutexes:

    CID1241484 Data race condition
    CID1241486 Data race condition
    CID1256173 Thread deadlock

Version-Release number of selected component (if applicable): master


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-12-03 16:45:40 CET ---

REVIEW: http://review.gluster.org/9230 (ec: Fix mutex related coverity scan issues) posted (#1) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2014-12-04 20:36:36 CET ---

COMMIT: http://review.gluster.org/9230 committed in master by Vijay Bellur (vbellur) 
------
commit 30ae004100067f52fe156098ffb215417db5559e
Author: Xavier Hernandez <xhernandez>
Date:   Wed Dec 3 16:42:31 2014 +0100

    ec: Fix mutex related coverity scan issues
    
    This patch solves 3 issues detected by coverity scan:
    
        CID1241484 Data race condition
        CID1241486 Data race condition
        CID1256173 Thread deadlock
    
    With this patch, inode lock is never acquired inside a region locked
    with fop->lock.
    
    Change-Id: I35c4633efd1b68b9f72b42661fa7c728b1f52c6a
    BUG: 1170254
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9230
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 1 Anand Avati 2014-12-05 08:23:36 UTC
REVIEW: http://review.gluster.org/9244 (ec: Fix mutex related coverity scan issues) posted (#1) for review on release-3.6 by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2014-12-17 14:58:51 UTC
REVIEW: http://review.gluster.org/9244 (ec: Fix mutex related coverity scan issues) posted (#2) for review on release-3.6 by Xavier Hernandez (xhernandez)

Comment 3 Anand Avati 2015-01-05 06:58:35 UTC
COMMIT: http://review.gluster.org/9244 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit 8bfe216b8297129833d3af5a66984b9b9bf0046c
Author: Xavier Hernandez <xhernandez>
Date:   Wed Dec 3 16:42:31 2014 +0100

    ec: Fix mutex related coverity scan issues
    
    This patch solves 3 issues detected by coverity scan:
    
        CID1241484 Data race condition
        CID1241486 Data race condition
        CID1256173 Thread deadlock
        CID1257622 Thread deadlock
    
    With this patch, inode lock is never acquired inside a region locked
    with fop->lock.
    
    This is a backport of http://review.gluster.org/9230/ and
    http://review.gluster.org/9263/
    
    Change-Id: I35c4633efd1b68b9f72b42661fa7c728b1f52c6a
    BUG: 1170954
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9244
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 4 Raghavendra Bhat 2015-02-11 09:10:58 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.2, please reopen this bug report.

glusterfs-3.6.2 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.6.2.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978
[2] http://news.gmane.org/gmane.comp.file-systems.gluster.user
[3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137


Note You need to log in before you can comment on or make changes to this bug.