+++ This bug was initially created as a clone of Bug #1133456 +++ +++ This bug was initially created as a clone of Bug #1132026 +++ Description of problem: ======================= By default we append nouuid xfs option for every snapshot brick during creation. But if the original volume brick already has nouuid option set and during snapshot creation another nouuid option is appended than we endup in having 2 nouuid option for same brick. For example: ============= Original volume brick xfs options: /dev/mapper/RHS_vg2-RHS_lv2 on /rhs/brick2 type xfs (rw,noatime,allocsize=1MiB,noattr2,barrier,nogrpid,ihashsize=0,noikeep,inode64,largeio,logbufs=4,noalign,nouuid,osyncisosync,quota,gquota,swalloc) Snapshoted brick xfs options: /dev/mapper/RHS_vg2-8e87d5ac707343c4b42ea779befc53b2_0 on /var/run/gluster/snaps/8e87d5ac707343c4b42ea779befc53b2/brick1 type xfs (rw,noatime,allocsize=1MiB,noattr2,barrier,nogrpid,ihashsize=0,noikeep,inode64,largeio,logbufs=4,noalign,nouuid,osyncisosync,quota,gquota,swalloc,nouuid) Version-Release number of selected component (if applicable): ============================================================= glusterfs-3.6.0.27-1.el6rhs.x86_64 How reproducible: ================= always Steps to Reproduce: =================== 1. Create a ThinLv brick with nouuid option 2. Create a volume having the above brick 3. Create a snapshot of the volume Actual results: =============== Newly created snapshoted brick will have entries of nouuid Expected results: ================== If the parent(original) brick already has nouuid, we dont need to add it explicitly. --- Additional comment from Anand Avati on 2014-08-25 04:13:57 EDT --- REVIEW: http://review.gluster.org/8526 (glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika) --- Additional comment from Anand Avati on 2014-11-12 23:23:51 EST --- REVIEW: http://review.gluster.org/8526 (glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika) --- Additional comment from Anand Avati on 2014-11-13 06:59:13 EST --- REVIEW: http://review.gluster.org/8526 (glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika) --- Additional comment from Anand Avati on 2014-11-13 23:10:06 EST --- COMMIT: http://review.gluster.org/8526 committed in master by Krishnan Parthasarathi (kparthas) ------ commit f3f7f2a2048359db67875a54a96dbf5a46f7bff3 Author: vmallika <vmallika> Date: Thu Nov 13 07:11:00 2014 +0530 glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option Change-Id: I2841d2ac371a3e9505f6061f35d1d447946c0bae BUG: 1133456 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/8526 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
REVIEW: http://review.gluster.org/9303 (glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option) posted (#1) for review on release-3.6 by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9303 (glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option.) posted (#2) for review on release-3.6 by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9303 (glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option) posted (#3) for review on release-3.6 by Sachin Pandit (spandit)
COMMIT: http://review.gluster.org/9303 committed in release-3.6 by Raghavendra Bhat (raghavendra) ------ commit 7d89b78a56f1eed261a56dcb671ba8b804c2bf5a Author: Sachin Pandit <spandit> Date: Fri Dec 19 03:24:23 2014 +0530 glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option Change-Id: I2841d2ac371a3e9505f6061f35d1d447946c0bae BUG: 1175732 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/8526 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas> Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/9303 Reviewed-by: Raghavendra Bhat <raghavendra>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.2, please reopen this bug report. glusterfs-3.6.2 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.6.2. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978 [2] http://news.gmane.org/gmane.comp.file-systems.gluster.user [3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137