Description of problem: Currently in marker as a process of accounting quota, it does multiple STACK WIND and UNWIND. This makes code more complicated. By changing this to SYNCOP, it will be more readable and also easier to debug the problems.
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#9) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#10) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#11) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#12) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#13) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#14) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#15) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#16) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#17) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#18) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#19) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring by replacing WIND and UNWIND with SYNCOP) posted (#20) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#21) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#22) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach.) posted (#23) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach.) posted (#24) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach.) posted (#25) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#26) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach.) posted (#27) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#28) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach.) posted (#29) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#30) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#31) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#32) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#33) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#34) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#35) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9839 (Fix dictionary leaks in ancestry-building code) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach) posted (#36) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9839 (Fix dictionary leaks in ancestry-building code.) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)
COMMIT: http://review.gluster.org/9839 committed in master by Vijay Bellur (vbellur) ------ commit 8612553ffe3d87481c70911a9b8491fb5f4139b5 Author: Pranith Kumar K <pkarampu> Date: Mon Mar 9 19:35:14 2015 +0530 Fix dictionary leaks in ancestry-building code. Change-Id: I7a4a24ed95f897d1c14d89f3869c20ba40f85b7f BUG: 1188636 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/9839 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijaikumar Mallikarjuna <vmallika> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/9567 (Quota/marker : Support for inode quota.) posted (#37) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota/marker : Support for inode quota.) posted (#38) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota/marker : Support for inode quota.) posted (#39) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9858 (syncop: assign lk_owner for the newly created frame) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)
REVIEW: http://review.gluster.org/9567 (Quota/marker : Support for inode quota) posted (#40) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota: RFE, marker refactoring with syncop approach.) posted (#41) for review on master by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/9567 (Quota/marker : Support for inode quota) posted (#42) for review on master by Sachin Pandit (spandit)
COMMIT: http://review.gluster.org/9858 committed in master by Vijay Bellur (vbellur) ------ commit 9f71b25f34a24741496875ab947f6f9c95ec277f Author: vmallika <vmallika> Date: Wed Mar 11 18:03:47 2015 +0530 syncop: assign lk_owner for the newly created frame syncop_inodelk doesn't work properly as lk_owner is not set in the frame created by 'synctask_create'. There is a possibility that more than one thread can acquire inode lock with syncop_inodelk Change-Id: I8193edb0d24b3a6e3a3f6a0c5d7ab5a1be8e7daf BUG: 1188636 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/9858 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-by: Pranith Kumar Karampuri <pkarampu> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/9567 (Quota/marker : Support for inode quota) posted (#43) for review on master by Vijaikumar Mallikarjuna (vmallika)
COMMIT: http://review.gluster.org/9567 committed in master by Vijay Bellur (vbellur) ------ commit 7970183f4c730d4aca3cfaa106fde015a0fbc415 Author: vmallika <vmallika> Date: Tue Mar 17 20:05:19 2015 +0530 Quota/marker : Support for inode quota Currently, the only way to retrieve the number of files/objects in a directory or volume is to do a crawl of the entire directory/volume. This is expensive and is not scalable. The new mechanism proposes to store count of objects/files as part of an extended attribute of a directory. Each directory's extended attribute value will indicate the number of files/objects present in a tree with the directory being considered as the root of the tree. Currently file usage is accounted in marker by doing multiple FOPs like setting and getting xattrs. Doing this with STACK WIND and UNWIND can be harder to debug as involves multiple callbacks. In this code we are replacing current mechanism with syncop approach as syncop code is much simpler to follow and help us implement inode quota in an organized way. Change-Id: Ibf366fbe07037284e89a241ddaff7750fc8771b4 BUG: 1188636 Signed-off-by: vmallika <vmallika> Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/9567 Reviewed-by: Vijay Bellur <vbellur> Tested-by: Vijay Bellur <vbellur>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user