Bug 1212182 - nfs : racy condition in export/netgroup feature
Summary: nfs : racy condition in export/netgroup feature
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1211913
Blocks: glusterfs-3.7.0
TreeView+ depends on / blocked
 
Reported: 2015-04-15 18:26 UTC by Niels de Vos
Modified: 2015-05-14 17:46 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1211913
Environment:
Last Closed: 2015-05-14 17:29:27 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2015-04-15 18:26:40 UTC
+++ This bug was initially created as a clone of Bug #1211913 +++

Description of problem:

For export/netgroup feature we will run a thread in background which will fetch/refresh contents of export/netgroup file. This thread is not cleaned up properly

Version-Release number of selected component (if applicable):
3.7

How reproducible:
rarely


Actual results:
coredump is generated.

Expected results:
Should reach such race conditions

Additional info:

--- Additional comment from Anand Avati on 2015-04-15 10:43:56 CEST ---

REVIEW: http://review.gluster.org/10250 (nfs : fix for coredump caused by export/netgroup feature in th regression failure) posted (#1) for review on master by jiffin tony Thottan (jthottan)

--- Additional comment from Anand Avati on 2015-04-15 10:45:34 CEST ---

REVIEW: http://review.gluster.org/10250 (nfs : fix for coredump caused by export/netgroup feature in the regression failure) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 1 Niels de Vos 2015-04-15 18:27:35 UTC
This bug has been opened to backport the changes from bug 1211913 to the release-3.7 branch.

Comment 2 Anand Avati 2015-05-07 05:36:17 UTC
REVIEW: http://review.gluster.org/10618 (nfs : fix for coredump caused by export/netgroup feature in the regression) posted (#1) for review on release-3.7 by jiffin tony Thottan (jthottan)

Comment 3 Anand Avati 2015-05-07 22:09:41 UTC
REVIEW: http://review.gluster.org/10655 (nfs: allocate the auth_cache->cache_dict on auth_cache_init()) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 4 Anand Avati 2015-05-08 03:07:06 UTC
COMMIT: http://review.gluster.org/10655 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 44d860c7061f7ef375001251876d91c2ec2db86f
Author: Niels de Vos <ndevos>
Date:   Fri May 8 00:05:25 2015 +0200

    nfs: allocate the auth_cache->cache_dict on auth_cache_init()
    
    It seems possible that auth_cache->cache_dict is not always allocated
    before it is accessed. Instead of allocating the dict upon the 1st
    access, just create it in auth_cache_init().
    
    Cherry picked from commit eb8847703b8560a045e7ed0336f895bcceda98ea:
    > Change-Id: I00e60522478b433cb0aae0c1f0948eac544dfd2b
    > URL: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10710
    > BUG: 1143880
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/10600
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    > Reviewed-by: jiffin tony Thottan <jthottan>
    > Tested-by: NetBSD Build System
    
    Change-Id: I00e60522478b433cb0aae0c1f0948eac544dfd2b
    BUG: 1212182
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/10655
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>

Comment 5 Niels de Vos 2015-05-14 17:29:27 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:35:56 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:38:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:46:49 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.