+++ This bug was initially created as a clone of Bug #1213773 +++ Description of problem: glfs_h_poll_upcall() is used to poll upcall events which is stored in upcall list. If list contains invalid entries it should be removed , so further polling of the same can be avoided. Version-Release number of selected component (if applicable): mainline How reproducible: always Actual results: polling is done for invalid entries Expected results: polling should not done for invalid entries Additional info: This issue was faced while running perf test on pnfs. snippet from gfapi logs : [2015-04-21 07:24:39.734836] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle [2015-04-21 07:24:39.768259] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle [2015-04-21 07:24:39.803004] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle [2015-04-21 07:24:39.844828] W [glfs-handleops.c:1163:pub_glfs_h_create_from_handle] 0-meta-autoload: inode refresh of 204a66bc-f262-4a8e-b5e3-9be4fd5bf07c failed: Stale file handle snippet from nfs-ganesha.log 21/04/2015 05:17:19 : epoch 5535049d : heka-client-13.gdev.lab.eng.bos.redhat.com : ganesha.nfsd-19940[fsal_up_0x7f811] GLUSTERFSAL_UP_Thread :FSAL_UP :CRIT :OPENHANDLE_INODE_UPDATE failed for 0x7f811ae80780. rc -1 errno 12 (Cannot allocate memory) reason 2 21/04/2015 05:17:20 : epoch 5535049d : heka-client-13.gdev.lab.eng.bos.redhat.com : ganesha.nfsd-19940[fsal_up_0x7f811] GLUSTERFSAL_UP_Thread :FSAL_UP :CRIT :OPENHANDLE_INODE_UPDATE failed for 0x7f811ae80780. rc -1 errno 12 (Cannot allocate memory) reason 2 21/04/2015 05:17:20 : epoch 5535049d : heka-client-13.gdev.lab.eng.bos.redhat.com : ganesha.nfsd-19940[fsal_up_0x7f811] GLUSTERFSAL_UP_Thread :FSAL_UP :CRIT :OPENHANDLE_INODE_UPDATE failed for 0x7f811ae80780. rc -1 errno 12 (Cannot allocate memory) reason 2 --- Additional comment from Anand Avati on 2015-04-22 13:10:13 EDT --- REVIEW: http://review.gluster.org/10341 (gfapi: Skip and delete the upcall entry if not found) posted (#1) for review on master by soumya k (skoduri) --- Additional comment from Anand Avati on 2015-04-27 04:54:13 EDT --- REVIEW: http://review.gluster.org/10341 (gfapi: Skip and delete the upcall entry if not found) posted (#2) for review on master by soumya k (skoduri) --- Additional comment from Anand Avati on 2015-05-04 08:28:30 EDT --- REVIEW: http://review.gluster.org/10341 (gfapi: Skip and delete the upcall entry if not found) posted (#4) for review on master by soumya k (skoduri)
REVIEW: http://review.gluster.org/10565 (gfapi: Skip and delete the upcall entry if not found) posted (#1) for review on release-3.7 by soumya k (skoduri)
REVIEW: http://review.gluster.org/10565 (gfapi: Skip and delete the upcall entry if not found) posted (#2) for review on release-3.7 by Kaleb KEITHLEY (kkeithle)
COMMIT: http://review.gluster.org/10565 committed in release-3.7 by Vijay Bellur (vbellur) ------ commit add1ee3a479395feba36afd37d16b9a635669715 Author: Soumya Koduri <skoduri> Date: Wed Apr 22 22:34:41 2015 +0530 gfapi: Skip and delete the upcall entry if not found We could run into situations where in gfapi received a upcall notification for a file and the file may have got deleted by then. Hence, incase of error while trying to create handle from gfid, log it, delete the entry and return with CBK_NULL reason. Change-Id: I191f10f44d6804be07734a6be63a3ca08f455f0e BUG: 1218566 Signed-off-by: Soumya Koduri <skoduri> Reviewed-on: http://review.gluster.org/10341 Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-on: http://review.gluster.org/10565 Tested-by: NetBSD Build System
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user