Bug 1218857 - Clean up should not empty the contents of the global config file
Summary: Clean up should not empty the contents of the global config file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: ganesha-nfs
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Meghana
QA Contact:
URL:
Whiteboard:
: 1218554 (view as bug list)
Depends On: 1218854
Blocks: glusterfs-3.7.0
TreeView+ depends on / blocked
 
Reported: 2015-05-06 04:32 UTC by Meghana
Modified: 2015-09-01 02:54 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1218854
Environment:
Last Closed: 2015-05-14 17:29:37 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Meghana 2015-05-06 04:32:54 UTC
+++ This bug was initially created as a clone of Bug #1218854 +++

Description of problem:
The global config file will need new blocks to support client lock recovery.
Current cleanup function empties the entire file. Deleting only "include"
lines in the config file.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-05-06 00:30:47 EDT ---

REVIEW: http://review.gluster.org/10592 (NFS-Ganesha : Do not empty global config file when cluster is torn) posted (#1) for review on master by Meghana M (mmadhusu)

Comment 1 Anand Avati 2015-05-06 04:40:26 UTC
REVIEW: http://review.gluster.org/10593 (NFS-Ganesha : Do not empty global config file when cluster is torn) posted (#1) for review on release-3.7 by Meghana M (mmadhusu)

Comment 2 Anand Avati 2015-05-06 08:21:26 UTC
REVIEW: http://review.gluster.org/10593 (NFS-Ganesha : Do not empty global config file when cluster is torn) posted (#2) for review on release-3.7 by Meghana M (mmadhusu)

Comment 3 Anand Avati 2015-05-07 10:42:21 UTC
REVIEW: http://review.gluster.org/10593 (NFS-Ganesha: Add-node and delete-node changes in HA implementation) posted (#3) for review on release-3.7 by Meghana M (mmadhusu)

Comment 4 Anand Avati 2015-05-07 11:15:00 UTC
REVIEW: http://review.gluster.org/10593 (NFS-Ganesha : Do not empty global config file when cluster is torn) posted (#4) for review on release-3.7 by Meghana M (mmadhusu)

Comment 5 Anand Avati 2015-05-07 11:40:55 UTC
REVIEW: http://review.gluster.org/10635 (libgfapi : anonymous fd support) posted (#1) for review on release-3.7 by jiffin tony Thottan (jthottan)

Comment 6 Anand Avati 2015-05-07 17:29:37 UTC
COMMIT: http://review.gluster.org/10593 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit cfe56c96ff435f916a7017f3252717cf0df151d9
Author: Meghana Madhusudhan <mmadhusu>
Date:   Wed May 6 10:08:54 2015 +0530

    NFS-Ganesha : Do not empty global config file when cluster is torn
    
    The global config file will need new blocks to support client lock recovery.
    Current cleanup function empties the entire file. Deleting only "include"
    lines in the config file.
    
    This is the backport of the patch,
    http://review.gluster.org/#/c/10630/
    
    Change-Id: I15f7a7aa7bc4f2362abd15b28a8b709d93dc3d37
    BUG: 1218857
    Signed-off-by: Meghana Madhusudhan <mmadhusu>
    Reviewed-on: http://review.gluster.org/10593
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 7 Anand Avati 2015-05-07 19:12:03 UTC
REVIEW: http://review.gluster.org/10635 (libgfapi : anonymous fd support) posted (#2) for review on release-3.7 by Niels de Vos (ndevos)

Comment 8 Anand Avati 2015-05-08 06:50:12 UTC
COMMIT: http://review.gluster.org/10635 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 753a603ce3259f3c6667a48ff4001512941f9128
Author: Jiffin Tony Thottan <jthottan>
Date:   Wed Mar 11 14:20:48 2015 +0530

    libgfapi : anonymous fd support
    
          backport of http://review.gluster.org/#/c/9971/
    
    Anonymous fd's are floating fd assigned to a glusterfs client
    without a explicit file open. Here either it will create a new
    anonymous fd or existing anonymous fd in the client stack for
    requested file.The anonymous fd's are mainly used for IO's.
    This patch introduces two api's glfs_h_anonymous_read and
    glfs_h_anonymous_write which performs read and write respectively
    
    cherry-picked as fa0ad231745846918b2625d0e1a89c0a5c3c24dc
    >Change-Id: Id646f2220e8387b2f8bb244c848dc1db6761444f
    >BUG: 1204651
    >Signed-off-by: Jiffin Tony Thottan <jthottan>
    >Reviewed-by: Niels de Vos <ndevos>
    >Reviewed-on: http://review.gluster.org/9971
    >Tested-by: Gluster Build System <jenkins.com>
    >Signed-off-by: Jiffin Tony Thottan <jthottan>
    
    Change-Id: I6b01d88f92ad045e48debee23aa79f4517c6bdc2
    BUG: 1218857
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/10635
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 9 Niels de Vos 2015-05-14 17:29:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:36:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2015-05-14 17:38:21 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 12 Niels de Vos 2015-05-14 17:47:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 13 Niels de Vos 2015-05-22 09:17:14 UTC
*** Bug 1218554 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.