Bug 1334836 - [features/worm] - when disabled, worm xl should simply pass requested fops to its child xl
Summary: [features/worm] - when disabled, worm xl should simply pass requested fops to...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: unclassified
Version: 3.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1332460
Blocks: glusterfs-3.8.0
TreeView+ depends on / blocked
 
Reported: 2016-05-10 15:44 UTC by Joseph Elwin Fernandes
Modified: 2016-06-20 00:02 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1332460
Environment:
Last Closed: 2016-06-16 14:06:02 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Joseph Elwin Fernandes 2016-05-10 15:44:11 UTC
+++ This bug was initially created as a clone of Bug #1332460 +++

Description of problem:

Same as subject

I found this while testing another change, where the anon fd ctx in posix xl was already initialised by the time a write fop came in (and posix_writev() is where I was expecting the initialisation to have happened). Turns out the initialisation was being done in posix_fgetxattr() when the fop requested by shard was writev(). I traced the call and found that it is being wound by worm translator as part of writev() even though it was disabled on my setup (default configuration).
With server side translators, if they are disabled, they should simply pass fop requested by the parent down to their child(ren) without doing anything else.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-03 05:21:12 EDT ---

REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-05-04 02:20:21 EDT ---

REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#2) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-04 03:12:11 EDT ---

REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#3) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-04 09:44:30 EDT ---

REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#4) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-04 10:04:25 EDT ---

REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#5) for review on master by Karthik U S (ksubrahm)

Comment 1 Vijay Bellur 2016-05-17 02:21:43 UTC
REVIEW: http://review.gluster.org/14367 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#1) for review on release-3.8 by Joseph Fernandes

Comment 2 Vijay Bellur 2016-05-20 02:32:45 UTC
REVIEW: http://review.gluster.org/14367 (features/worm: When disabled, worm xlator must directly pass fops to its child xlator) posted (#2) for review on release-3.8 by Joseph Fernandes

Comment 3 Vijay Bellur 2016-05-24 08:34:49 UTC
COMMIT: http://review.gluster.org/14367 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 842ec2af2cb0a0fecc9da018a51814946b89231e
Author: Krutika Dhananjay <kdhananj>
Date:   Tue May 3 14:29:45 2016 +0530

    features/worm: When disabled, worm xlator must directly pass fops to its child xlator
    
    Backport of http://review.gluster.org/#/c/14182/
    
    > Change-Id: I56ea46c2743636ef7af5c85469cb2e186eadf21f
    > BUG: 1332460
    > Signed-off-by: Krutika Dhananjay <kdhananj>
    > Reviewed-on: http://review.gluster.org/14182
    > Smoke: Gluster Build System <jenkins.com>
    > Reviewed-by: Joseph Fernandes
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Niels de Vos <ndevos>
    > Signed-off-by: Joseph Fernandes <josferna>
    
    Change-Id: Ic3995e8e81ae22a0c31167e356b203acfff4194d
    BUG: 1334836
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/14367
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Joseph Fernandes
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Niels de Vos 2016-06-16 14:06:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.