Bug 815613 - coverity fixage implicate geo-replicate brokage
Summary: coverity fixage implicate geo-replicate brokage
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: geo-replication
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: ---
Assignee: Amar Tumballi
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 817967
TreeView+ depends on / blocked
 
Reported: 2012-04-24 04:10 UTC by Csaba Henk
Modified: 2015-12-01 16:45 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.4.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-24 17:53:15 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Csaba Henk 2012-04-24 04:10:28 UTC
Description of problem:

geo-rep does not work... yet again

Version-Release number of selected component (if applicable):


How reproducible:

very much indeed!

Steps to Reproduce:
1. gluster vol geo-rep MASTER SLAVE start
2. gluster vol geo-rep MASTER SLAVE start
3. gluster vol geo-rep MASTER SLAVE start
  
Actual results:

<empty line>
geo-replication command failed
geo-replication start option validation failed
geo-replication command failed
geo-replication start option validation failed
geo-replication command failed

Expected results:

Starting geo-replication session between MASTER & SLAVE has been successful
geo-replication session between MASTER & SLAVE already started
geo-replication command failed
geo-replication session between MASTER & SLAVE already started
geo-replication command failed

Additional info:

Bisected to http://review.gluster.com/3145

Comment 1 Amar Tumballi 2012-04-24 04:30:49 UTC
http://review.gluster.com/#patch,sidebyside,3145,3,xlators/mgmt/glusterd/src/glusterd-geo-rep.c 

Csaba, let me know what should be the behavior when 'fd' and 'pfd' are -1, because the coverity was complaining of possible negative value passed to systemcall.

Comment 2 Anand Avati 2012-04-24 20:32:07 UTC
CHANGE: http://review.gluster.com/3219 (glusterd: command check failure fixes) merged in master by Anand Avati (avati)


Note You need to log in before you can comment on or make changes to this bug.