Bug 948178 - do proper cleanup of the graph
Summary: do proper cleanup of the graph
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Raghavendra Bhat
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1032465
TreeView+ depends on / blocked
 
Reported: 2013-04-04 08:56 UTC by Raghavendra Bhat
Modified: 2014-04-17 11:41 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.5.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1032465 (view as bug list)
Environment:
Last Closed: 2014-04-17 11:41:28 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Raghavendra Bhat 2013-04-04 08:56:23 UTC 
Description of problem:
Upon graph change the old graph still exists and the xlator's fini is not called for the old graph. The inode contexts and the fd contexts remain in the memory till the lifetime of the inode/fd (in the new graph a new corresponding inode/fd would have been created and the active graph's inode/fd will be used for any further incoming request).

To avoid memory leak, do proper cleanup of the older graph whenever graph change happens.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Anand Avati 2013-04-04 09:01:16 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
Comment 2 Anand Avati 2013-04-04 09:01:35 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
Comment 3 Anand Avati 2013-04-04 09:01:51 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
Comment 4 Anand Avati 2013-04-04 09:02:09 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
Comment 5 Anand Avati 2013-04-04 10:36:09 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
Comment 6 Anand Avati 2013-04-04 10:36:26 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
Comment 7 Anand Avati 2013-04-04 10:36:42 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
Comment 8 Anand Avati 2013-04-04 10:36:58 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
Comment 9 Anand Avati 2013-04-04 18:14:20 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#3) for review on master by Raghavendra Bhat (raghavendra)
Comment 10 Anand Avati 2013-04-04 18:14:36 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#3) for review on master by Raghavendra Bhat (raghavendra)
Comment 11 Anand Avati 2013-04-04 18:14:52 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#3) for review on master by Raghavendra Bhat (raghavendra)
Comment 12 Anand Avati 2013-04-04 18:15:08 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#3) for review on master by Raghavendra Bhat (raghavendra)
Comment 13 Anand Avati 2013-04-04 20:06:05 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#4) for review on master by Raghavendra Bhat (raghavendra)
Comment 14 Anand Avati 2013-04-04 20:06:21 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#4) for review on master by Raghavendra Bhat (raghavendra)
Comment 15 Anand Avati 2013-04-04 20:06:37 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#4) for review on master by Raghavendra Bhat (raghavendra)
Comment 16 Anand Avati 2013-04-04 20:06:53 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#4) for review on master by Raghavendra Bhat (raghavendra)
Comment 17 Anand Avati 2013-04-08 08:43:38 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#5) for review on master by Raghavendra Bhat (raghavendra)
Comment 18 Anand Avati 2013-04-08 08:43:56 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#5) for review on master by Raghavendra Bhat (raghavendra)
Comment 19 Anand Avati 2013-04-08 08:44:13 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#5) for review on master by Raghavendra Bhat (raghavendra)
Comment 20 Anand Avati 2013-04-08 08:44:32 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#5) for review on master by Raghavendra Bhat (raghavendra)
Comment 21 Anand Avati 2013-04-10 08:55:02 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#6) for review on master by Raghavendra Bhat (raghavendra)
Comment 22 Anand Avati 2013-04-10 08:55:23 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#6) for review on master by Raghavendra Bhat (raghavendra)
Comment 23 Anand Avati 2013-04-10 08:55:41 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#6) for review on master by Raghavendra Bhat (raghavendra)
Comment 24 Anand Avati 2013-04-10 08:55:59 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#6) for review on master by Raghavendra Bhat (raghavendra)
Comment 25 Anand Avati 2013-04-22 12:15:55 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#7) for review on master by Raghavendra Bhat (raghavendra)
Comment 26 Anand Avati 2013-04-22 12:16:23 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#7) for review on master by Raghavendra Bhat (raghavendra)
Comment 27 Anand Avati 2013-04-22 12:16:42 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#7) for review on master by Raghavendra Bhat (raghavendra)
Comment 28 Anand Avati 2013-04-22 12:17:50 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#7) for review on master by Raghavendra Bhat (raghavendra)
Comment 29 Anand Avati 2013-05-09 12:52:17 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#8) for review on master by Raghavendra Bhat (raghavendra)
Comment 30 Anand Avati 2013-05-09 12:52:42 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#8) for review on master by Raghavendra Bhat (raghavendra)
Comment 31 Anand Avati 2013-05-09 12:53:01 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#8) for review on master by Raghavendra Bhat (raghavendra)
Comment 32 Anand Avati 2013-05-09 12:53:22 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#8) for review on master by Raghavendra Bhat (raghavendra)
Comment 33 Anand Avati 2013-05-14 05:40:37 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#9) for review on master by Raghavendra Bhat (raghavendra)
Comment 34 Anand Avati 2013-05-14 05:40:57 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#9) for review on master by Raghavendra Bhat (raghavendra)
Comment 35 Anand Avati 2013-05-14 05:41:16 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#9) for review on master by Raghavendra Bhat (raghavendra)
Comment 36 Anand Avati 2013-05-14 05:41:36 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#9) for review on master by Raghavendra Bhat (raghavendra)
Comment 37 Anand Avati 2013-06-10 10:32:48 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#10) for review on master by Raghavendra Bhat (raghavendra)
Comment 38 Anand Avati 2013-06-10 10:33:13 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#10) for review on master by Raghavendra Bhat (raghavendra)
Comment 39 Anand Avati 2013-06-10 10:33:35 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#10) for review on master by Raghavendra Bhat (raghavendra)
Comment 40 Anand Avati 2013-06-10 10:33:58 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#10) for review on master by Raghavendra Bhat (raghavendra)
Comment 41 Anand Avati 2013-06-12 07:58:27 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#11) for review on master by Raghavendra Bhat (raghavendra)
Comment 42 Anand Avati 2013-06-12 07:58:52 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#11) for review on master by Raghavendra Bhat (raghavendra)
Comment 43 Anand Avati 2013-06-12 07:59:14 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#11) for review on master by Raghavendra Bhat (raghavendra)
Comment 44 Anand Avati 2013-06-12 07:59:38 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#11) for review on master by Raghavendra Bhat (raghavendra)
Comment 45 Anand Avati 2013-06-18 09:14:55 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#12) for review on master by Raghavendra Bhat (raghavendra)
Comment 46 Anand Avati 2013-06-18 09:15:18 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#12) for review on master by Raghavendra Bhat (raghavendra)
Comment 47 Anand Avati 2013-06-18 09:15:42 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#12) for review on master by Raghavendra Bhat (raghavendra)
Comment 48 Anand Avati 2013-06-18 09:16:05 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#12) for review on master by Raghavendra Bhat (raghavendra)
Comment 49 Anand Avati 2013-06-18 10:38:37 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#13) for review on master by Raghavendra Bhat (raghavendra)
Comment 50 Anand Avati 2013-06-18 10:39:01 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#13) for review on master by Raghavendra Bhat (raghavendra)
Comment 51 Anand Avati 2013-06-18 10:39:25 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#13) for review on master by Raghavendra Bhat (raghavendra)
Comment 52 Anand Avati 2013-06-18 10:39:48 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#13) for review on master by Raghavendra Bhat (raghavendra)
Comment 53 Anand Avati 2013-06-18 11:27:26 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#14) for review on master by Raghavendra Bhat (raghavendra)
Comment 54 Anand Avati 2013-06-18 11:27:49 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#14) for review on master by Raghavendra Bhat (raghavendra)
Comment 55 Anand Avati 2013-06-18 11:28:12 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#14) for review on master by Raghavendra Bhat (raghavendra)
Comment 56 Anand Avati 2013-06-18 11:28:37 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#14) for review on master by Raghavendra Bhat (raghavendra)
Comment 57 Anand Avati 2013-07-24 19:53:07 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd: destroy the temporary graphs constructed for comparison) posted (#1) for review on master by Raghavendra Bhat (raghavendra)
Comment 58 Anand Avati 2013-07-25 05:54:41 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison) posted (#2) for review on master by Raghavendra Bhat (raghavendra)
Comment 59 Anand Avati 2013-07-25 09:33:16 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison) posted (#3) for review on master by Raghavendra Bhat (raghavendra)
Comment 60 Anand Avati 2013-07-26 09:08:35 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison) posted (#4) for review on master by Raghavendra Bhat (raghavendra)
Comment 61 Anand Avati 2013-08-02 12:01:16 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison) posted (#5) for review on master by Raghavendra Bhat (raghavendra)
Comment 62 Anand Avati 2013-08-22 13:15:04 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison) posted (#6) for review on master by Raghavendra Bhat (raghavendra)
Comment 63 Anand Avati 2013-08-26 12:49:45 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison) posted (#7) for review on master by Raghavendra Bhat (raghavendra)
Comment 64 Anand Avati 2013-09-03 12:53:55 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#15) for review on master by Raghavendra Bhat (raghavendra)
Comment 65 Anand Avati 2013-09-03 12:54:24 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#15) for review on master by Raghavendra Bhat (raghavendra)
Comment 66 Anand Avati 2013-09-03 12:54:52 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#15) for review on master by Raghavendra Bhat (raghavendra)
Comment 67 Anand Avati 2013-09-03 12:55:20 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#15) for review on master by Raghavendra Bhat (raghavendra)
Comment 68 Anand Avati 2013-09-12 09:53:31 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#16) for review on master by Raghavendra Bhat (raghavendra)
Comment 69 Anand Avati 2013-09-12 09:54:01 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#16) for review on master by Raghavendra Bhat (raghavendra)
Comment 70 Anand Avati 2013-09-12 09:54:30 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#16) for review on master by Raghavendra Bhat (raghavendra)
Comment 71 Anand Avati 2013-09-12 09:55:11 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#16) for review on master by Raghavendra Bhat (raghavendra)
Comment 72 Anand Avati 2013-09-13 07:18:45 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#17) for review on master by Raghavendra Bhat (raghavendra)
Comment 73 Anand Avati 2013-09-13 07:19:17 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#17) for review on master by Raghavendra Bhat (raghavendra)
Comment 74 Anand Avati 2013-09-13 07:19:50 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#17) for review on master by Raghavendra Bhat (raghavendra)
Comment 75 Anand Avati 2013-09-13 07:20:20 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#17) for review on master by Raghavendra Bhat (raghavendra)
Comment 76 Anand Avati 2013-09-26 07:04:04 UTC 
REVIEW: http://review.gluster.org/5388 (glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison) posted (#8) for review on master by Raghavendra Bhat (raghavendra)
Comment 77 Anand Avati 2013-09-27 09:36:48 UTC 
REVIEW: http://review.gluster.org/4778 (protocol/client: destroy the fd contexts of the client in fini) posted (#18) for review on master by Raghavendra Bhat (raghavendra)
Comment 78 Anand Avati 2013-09-27 09:37:47 UTC 
REVIEW: http://review.gluster.org/4776 (changes in performance xlators for graph cleanup) posted (#18) for review on master by Raghavendra Bhat (raghavendra)
Comment 79 Anand Avati 2013-09-27 09:38:57 UTC 
REVIEW: http://review.gluster.org/4777 (cluster: changes in cluster xlators and debug xlators for proper graph cleanup) posted (#18) for review on master by Raghavendra Bhat (raghavendra)
Comment 80 Anand Avati 2013-09-27 09:39:57 UTC 
REVIEW: http://review.gluster.org/4775 (core: changes for doing proper graph cleanup) posted (#18) for review on master by Raghavendra Bhat (raghavendra)
Comment 81 Anand Avati 2013-10-04 04:32:49 UTC 
COMMIT: http://review.gluster.org/5388 committed in master by Anand Avati (avati) 
------
commit dcfe4ab475c53cec7d117fb8052b26213a4b41db
Author: Raghavendra Bhat <raghavendra>
Date:   Thu Jul 25 01:14:48 2013 +0530

    glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison
    
    * The new and the oldgraphs which have been constructed whenever there is
      a volfile change (either reconfigure of the existing graph or creating
      a new graph) for comparison should be freed. Otherwise frequent graph
      changes will lead to huge memory leak
    
    Change-Id: I4faddb1aa9393b34cd2de6732e537a60f600026a
    BUG: 948178
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/5388
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
Comment 82 Niels de Vos 2014-04-17 11:41:28 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Note You need to log in before you can comment on or make changes to this bug.