I think we can, in case we are doing it please do not forget REST-API
Checked it on : oVirt Engine Version: 3.5.0-0.0.master.20140804172041.git23b558e.el6 VDSM Version: vdsm-4.16.1-6.gita4a4614.el6.x86_64 added /modified / removed disk description of a disk of a running VM . done by AdminGUI and restAPI. the operation succeeded GUI wise, but brakes xml structure. <description> element sometimes appears and sometimes not. all disk elements should always appear in xml, even if they have 'empty' value more details on BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1131800
(In reply to Gal Amado from comment #6) > Checked it on : > oVirt Engine Version: 3.5.0-0.0.master.20140804172041.git23b558e.el6 > VDSM Version: vdsm-4.16.1-6.gita4a4614.el6.x86_64 > > added /modified / removed disk description of a disk of a running VM . > done by AdminGUI and restAPI. > > the operation succeeded GUI wise, but brakes xml structure. > <description> element sometimes appears and sometimes not. > all disk elements should always appear in xml, even if they have 'empty' > value > > more details on BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1131800 This is inconsequential to this RFE - the same behavior is exhibited when cold-editing a disk's description. Moving BZ back to ON_QA, and lets use bug 1131800 to track the broken XML structure (which I'm not sure is wrong, BTW - see details there).
Allon, the description is not changed in the metadata of the volume also, the description stays empty in the metadata after editing it via the webadmin. Should this fact fail the test for this bug? And if not, why?
Compare the behaviors between "cold" edit and "hot" edit, if the result is the same, this is a different bug, if it only occurs with "hot" edit then this bug is not fixed
(In reply to Elad from comment #8) > Allon, the description is not changed in the metadata of the volume also, > the description stays empty in the metadata after editing it via the > webadmin. > Should this fact fail the test for this bug? And if not, why? We never updated the volume metadata, regardless of whether the VM is up or not - see bug 1047621. Fixing that is not in the scope of this RFE, and should not fail the test for it.
(In reply to Allon Mureinik from comment #10) > (In reply to Elad from comment #8) > > Allon, the description is not changed in the metadata of the volume also, > > the description stays empty in the metadata after editing it via the > > webadmin. > > Should this fact fail the test for this bug? And if not, why? > We never updated the volume metadata, regardless of whether the VM is up or > not - see bug 1047621. > Fixing that is not in the scope of this RFE, and should not fail the test > for it. Thanks, it will be tested accordingly
This is has nothing to do with editing while the VM is active - if there's a difference in the way we represent the XML, it should be tracked in bug 1131800.
Original Request: 1. What is the nature and description of the request? Unable to edit description of a vDisk associated with a VM without powering down the VM first.Since the description appear to be simply labels and do not affect the database back end, we can see no reason why this should not be possible. 2. Why does the customer need this? (List the business requirements here) Freedom to amend and rename disks Aliases and Descriptions without having to power down the VM. The use of a disk can change during the lifecycle of a VM and we need the ability to easily change its description and possible Alias. 3. How would the customer like to achieve this? Allow editing of a disk whilst the associated VM remains online, via the webui, CLI and APIs. 4. For each functional requirement listed in question 4, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented. Spin up a VM and then attempt to edit an associated disk to change its Alias and Description fields.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-0158.html