Maor - Do we have clear flow for verification? We can't reproduce it and want to be sure we are going throw the code changes when we are verifying it.
IINM VDSM should still throw an exception as before: Thread-1846::ERROR::2014-05-04 15:40:44,971::hsm::2379::Storage.HSM::(connectStorageServer) Could not connect to storageServer Traceback (most recent call last): File "/usr/share/vdsm/storage/hsm.py", line 2376, in connectStorageServer conObj.connect() File "/usr/share/vdsm/storage/storageServer.py", line 359, in connect iscsi.addIscsiNode(self._iface, self._target, self._cred) File "/usr/share/vdsm/storage/iscsi.py", line 166, in addIscsiNode iscsiadm.node_login(iface.name, portalStr, targetName) File "/usr/share/vdsm/storage/iscsiadm.py", line 295, in node_login raise IscsiNodeError(rc, out, err) IscsiNodeError: (8, ['Logging in to [iface: eth0.1, target: All that needs to be check is that we get the following message in the log: "Could not connect Host {0} - {1} to Iscsi Storage Server. T he exception is: {2}" That way, you should know that we got an exception, and engine will still finish with success
After several tries, we couldn't hit the relevant flow - Can't verify for sure. Following my email with DEV/PM - closing as works for me.
Since this bug was fixed but I'm unable to get the iscsiNodeError in vdsm as part of network replacement inside the iscsi bond, which was trigger the internal engine error, I'm closing this bug as UPSTREAM