Description of problem: Since the change in the UI of powertop I was not able to actually make it work. In the old UI, one would use the arrow keys to navigate through the settings and tune them. With the new UI, using the arrow key in the front page does nothing, it just moves the page and the user has to use the <tab> key to arrive to the `Tunables` tab where action can be taken. I learned this last week-end, this new behavior was really not easily discoverable for me. Maybe in the bottom bar where is mentioned `<ESC> Exit` could be also mentioned that <tab> is used to navigate through the different pages/panels/tabs. Version-Release number of selected component (if applicable): powertop-2.7-2.fc21.x86_64 How reproducible: Always (if you don't know it) Steps to Reproduce: 1. Start powertop 2. Ignore that <tab> can be used to navigate 3. Try using the arrow keys as you did before the new UI Actual results: You cannot change any settings, the whole page moves Expected results: An information message? Or more simply, mentioning at the bottom of the page that one should use <tab> to navigate Additional info:
Offer a fix upstream: https://github.com/fenrus75/powertop/pull/19
Thanks for the report and patch. Please also add "Shift + Tab". I will apply your patch downstream.
(In reply to Jaroslav Škarvada from comment #2) > Please also add "Shift + Tab". > I.e: + mvwprintw(bottom_line, 0,0, _("<ESC> Exit | <TAB> / <Shift + TAB> Navigate |")); or similarly.
Updated on github. Btw, are you on the upstream mailing-list? It seems to be the place to submit patches but I am not subscribed and do not feel like doing so just for a patch.
(In reply to Pierre-YvesChibon from comment #4) > Updated on github. > Thanks. > Btw, are you on the upstream mailing-list? > Yes. > It seems to be the place to submit patches but I am not subscribed and do > not feel like doing so just for a patch. > In the past Arjan also merged pull requests from github without problem, I don't know whether Alexandra do the same. But no problem, I will forward your patch there. At least it will get more attention. IIRC it was also possible to send to the list without registration (moderated).
Created attachment 990432 [details] Proposed patch (In reply to Pierre-YvesChibon from comment #4) I think the patch can be still improved. This mod could ease the translation, please update the pull request. I haven't sent the patch upstream yet, feel free to send it yourself, or let me know if you need forward.
Thanks for the change, I had started with something like this but I was not sure the two `%s` were valid (and how to specify the two arguments), so instead I used the same approach as elsewhere in the code: src/tuning/tuning.cpp: create_tab("Tunables", _("Tunables"), w, _(" <ESC> Exit | <Enter> Toggle tunable | <r> Window refresh"));
Shall I just incorporate your changes into a commit in my branch, or do you want to send me a git format-patch (thus keeping the attribution to you :))
(In reply to Pierre-YvesChibon from comment #7) > Thanks for the change, I had started with something like this but I was not > sure the two `%s` were valid (and how to specify the two arguments), so > instead I used the same approach as elsewhere in the code: > > src/tuning/tuning.cpp: create_tab("Tunables", _("Tunables"), w, _(" <ESC> > Exit | <Enter> Toggle tunable | <r> Window refresh")); Of course, the coding style of the project is probably inconsistent (as usually :), but the proposed change is definitely better for translators.
(In reply to Pierre-YvesChibon from comment #8) > Shall I just incorporate your changes into a commit in my branch, or do you > want to send me a git format-patch (thus keeping the attribution to you :)) Just incorporate the change. I send dozens patches daily to different projects, so no need to attribute simple improvement of UI improving one-liner (or nearly one-liner :)
Thanks, pull-request updated! :)
Upstream is asking on github for the patch to be sent to the list. Is this something you could do?
(In reply to Pierre-YvesChibon from comment #12) > Upstream is asking on github for the patch to be sent to the list. Is this > something you could do? NP, forwarded.
Thanks!