Bug 1510392 - Build option -DLEATHERMAN_USE_CATCH=OFF breaks dependent builds
Summary: Build option -DLEATHERMAN_USE_CATCH=OFF breaks dependent builds
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: leatherman
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1506504
TreeView+ depends on / blocked
 
Reported: 2017-11-07 10:08 UTC by James Hogarth
Modified: 2017-11-07 10:50 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-07 10:50:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description James Hogarth 2017-11-07 10:08:18 UTC
Description of problem:
Packages depending on leatherman just #include <catch.hpp> and expect it to be part of leatherman.

The build option removes it entirely so it cannot be relied on anymore.

As it's just used for testing and no part of the compiled lib it's safe to not enforce an unbundling to remove it.

See breakage here: 
https://kojipkgs.fedoraproject.org//work/tasks/768/22970768/build.log

See working version here:
https://copr-be.cloud.fedoraproject.org/results/jhogarth/facter3/fedora-rawhide-x86_64/00652818-cpp-hocon/build.log.gz

Comment 1 James Hogarth 2017-11-07 10:50:30 UTC
Since this is breaking the build of my new package I'm fixing this as a ProvenPackager.

Feel free to tweak my fix if you need to.

I'm only making the fix in rawhide as that's where I need to build facter3.


Note You need to log in before you can comment on or make changes to this bug.