Bug 2210485 - Review Request: golang-github-minio-highwayhash - Native Go version of HighwayHash
Summary: Review Request: golang-github-minio-highwayhash - Native Go version of Highwa...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1939310
TreeView+ depends on / blocked
 
Reported: 2023-05-27 20:10 UTC by Mark E. Fuller
Modified: 2023-06-11 19:49 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-11 19:49:00 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Mark E. Fuller 2023-05-27 20:10:06 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/05969885-golang-github-minio-highwayhash/golang-github-minio-highwayhash.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/nats-server/fedora-rawhide-x86_64/05969885-golang-github-minio-highwayhash/golang-github-minio-highwayhash-1.0.2-1.fc39.src.rpm
Description: Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM. Able to process over 10 GB/sec on a single core on Intel CPUs - https://en.wikipedia.org/wiki/HighwayHash
Fedora Account System Username: fuller

Comment 1 Mikel Olasagasti Uranga 2023-06-07 12:09:37 UTC
Two issues with this spec:

golang-github-minio-highwayhash-devel.noarch: E: summary-too-long Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM. Able to process over 10 GB/sec on a single core on Intel CPUs - https://en.wikipedia.org/wiki/HighwayHash

Also, not sure if including URLs in description is a good idea.


And more important:

> BuildError: The following noarch package built differently on different architectures: golang-github-minio-highwayhash-devel-1.0.2-1.fc39.noarch.rpm
> rpmdiff output was:
> removed     REQUIRES golang(golang.org/x/sys/cpu)

You can check at https://koji.fedoraproject.org/koji/taskinfo?taskID=101901699

Look at golang-github-aead-chacha20.spec or golang-x-crypto.spec to see how this can be fixed.

Comment 3 Mikel Olasagasti Uranga 2023-06-07 19:28:53 UTC
Both, the spec file and the spec file in srpm are the same as the old ones.

Comment 5 Mikel Olasagasti Uranga 2023-06-09 14:35:15 UTC
> golang-github-minio-highwayhash-devel.noarch: E: summary-too-long Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM.
> golang-github-minio-highwayhash-devel.noarch: W: summary-ended-with-dot Native Go version of HighwayHash with optimized assembly implementations on Intel and ARM.

Fix those and I'll approve the package.

Comment 7 Mikel Olasagasti Uranga 2023-06-11 18:35:33 UTC
Did you remove the fix for "golang(golang.org/x/sys/cpu)"?

Comment 9 Mikel Olasagasti Uranga 2023-06-11 19:31:43 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 10 Fedora Admin user for bugzilla script actions 2023-06-11 19:35:03 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-minio-highwayhash

Comment 11 Fedora Update System 2023-06-11 19:47:10 UTC
FEDORA-2023-0ec75909f7 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0ec75909f7

Comment 12 Fedora Update System 2023-06-11 19:49:00 UTC
FEDORA-2023-0ec75909f7 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.