Bug 583869 - Review Request: python-plwm - python module for making window managers for keyboard-loving programmers
Summary: Review Request: python-plwm - python module for making window managers for ke...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 12
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hiemanshu Sharma
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 583459
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-20 04:32 UTC by Rangeen Basu Roy Chowdhury
Modified: 2010-12-03 15:40 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-12-03 15:40:09 UTC
Type: ---
Embargoed:
hiemanshu: fedora-review?


Attachments (Terms of Use)

Description Rangeen Basu Roy Chowdhury 2010-04-20 04:32:40 UTC
Spec URL: http://sherry151.fedorapeople.org/python-plwm.spec
SRPM URL: http://sherry151.fedorapeople.org/python-plwm-2.7-0.1.rc1.fc12.src.rpm
Description: PLWM is a Python package, containing classes suitable for implementing a window manager. PLWM is also a window manager, using the PLWM package.

Comment 1 Rahul Sundaram 2010-04-20 05:07:14 UTC
[ Assuming you are only interested in maintaining this for Fedora 13 and above]

You don't have to define the Python macros on top.  They are done automatically by RPM itself in Fedora 13.  Read the Fedora Python packaging guidelines carefully.  

https://fedoraproject.org/wiki/Packaging:Python

You should also inquire with upstream about the Python 3 status of this module

You can remove the buildroot definition and cleaning of buildroot in %install section.   These are not necessary anymore.  Also remove the commented out %clean section 

You should also add a comment on each of the patches with a short description of what it does and upstream status of the patches.  Of course, you haven't filed it upstream or informed the upstream developer yet of these changes,  now would be a good time to do so.

Comment 2 Rangeen Basu Roy Chowdhury 2010-04-20 05:50:29 UTC
I want to maintain this for F12 as well. Also I have a F12 installation and so it will be easier for me to test the packages. So the python macros are necessary and so are the %clean and the buildroot cleanup in the %install section. Tested build on F-13 as well.

Comment 3 Hiemanshu Sharma 2010-04-20 05:52:31 UTC
I am taking this package up for review.!

Comment 4 Hiemanshu Sharma 2010-05-03 09:09:04 UTC
Please correct the source provided in the srpm. The md5sum and time stamps does not match.

Comment 7 Rangeen Basu Roy Chowdhury 2010-05-30 11:23:47 UTC
Updated Spec file
http://sherry151.fedorapeople.org/python-plwm.spec
http://sherry151.fedorapeople.org/python-plwm-2.7-0.3.rc1.fc13.src.rpm

Reverting back to the name python-plwm as it is not a Window manager by itself and is rather a python module.

Comment 8 Bug Zapper 2010-11-03 16:44:27 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 9 Bug Zapper 2010-12-03 15:40:09 UTC
Fedora 12 changed to end-of-life (EOL) status on 2010-12-02. Fedora 12 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.