Spec URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp.spec SRPM URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp-0.1-0.1.839svn.fc12.src.rpm Description: GYP is a tool to generates native Visual Studio, Xcode and SCons and/or make build files from a platform-independent input format. Its syntax is a universal cross-platform build representation that still allows sufficient per-platform flexibility to accommodate irreconcilable differences.
Some notes: ! Unneeded macros - You can remove %python_sitearch definition because it is uses nowhere. * Release -------------------------------------------------------- Release: 0.1.%{?revision:%{revision}svn}%{?dist} -------------------------------------------------------- - Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}" * BuildRoot - BuildRoot tag is no longer needed on Fedora and EPEL6: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * BR for python - Please specify python2 or python3. ref: https://fedoraproject.org/wiki/Packaging/Python#BuildRequires - Build fails on F-12 without BR: python2-devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955 * %{__python} setup.py install - Maybe there is only small difference, however I guess we usually add "--skip-build" to "python setup.py install".
(In reply to comment #1) > Some notes: > > ! Unneeded macros > - You can remove %python_sitearch definition because it is uses nowhere. It was necessary to build on f12: https://fedoraproject.org/wiki/Packaging:Python#Macros > * Release > -------------------------------------------------------- > Release: 0.1.%{?revision:%{revision}svn}%{?dist} > -------------------------------------------------------- > - Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}" You're right. fixed. > > * BuildRoot > - BuildRoot tag is no longer needed on Fedora and EPEL6: > https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag fixed. > > * BR for python > - Please specify python2 or python3. ref: > https://fedoraproject.org/wiki/Packaging/Python#BuildRequires > > - Build fails on F-12 without BR: python2-devel: > http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955 Okay, fixed. > * %{__python} setup.py install > - Maybe there is only small difference, however I guess we usually > add "--skip-build" to "python setup.py install". Sure. updated with: Spec URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp.spec SRPM URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp-0.1-0.2.839svn.fc12.src.rpm
Okay. (In reply to comment #2) > (In reply to comment #1) > > Some notes: > > > > ! Unneeded macros > > - You can remove %python_sitearch definition because it is uses nowhere. > > It was necessary to build on f12: > https://fedoraproject.org/wiki/Packaging:Python#Macros - Well, what I meant here is while %python_sitelib definition is needed for F=12, %python_sitearch definition is unneeded (because this is noarch), however not a blocker. --------------------------------------------------------------- This package (gyp) is APPROVED by mtasaka ---------------------------------------------------------------
Ah, yep. just copy and paste that there. anyway, thank you for the review. New Package SCM Request ======================= Package Name: gyp Short Description: Generate Your Projects Owners: tagoh Branches: f12 f13 f14 InitialCC:
Git done (by process-git-requests).
Thanks. the packages has been built.
Package Change Request ====================== Package Name: gyp New Branches: el5 el6 Owners: tagoh InitialCC:
Package Change Request ====================== Package Name: gyp New Branches: epel7 Owners: tagoh