Spec URL: http://people.freedesktop.org/~whot/libwacom/libwacom.spec SRPM URL: http://people.freedesktop.org/~whot/libwacom/libwacom-0.1-1.fc16.src.rpm Description: libwacom is a library that provides information about Wacom tablets and tools. This information can then be used by drivers or applications to tweak the UI or general settings to match the physical tablet.
builds fine in mock, rpmlint says: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm 5 packages and 0 specfiles checked; 0 errors, 0 warnings.
package name: ok spec file name: ok packaging guidelines: generally, ok. some minor cleanups possible: - BuildRoot: is no longer needed - rm -rf %{buildroot} in %install no longer needed - %clean no longer needed fine to leave these things in place if you want to minimize spec file changes for building on e.g. RHEL license: ok license: field ok license file: ok spec language: ok spec readable: ok upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libs: ok relocatable: ok directory ownership: looks like you need to own %{_datadir}/libwacom %{_includedir}/libwacom-1.0 %{_includedir}/libwacom-1.0/libwacom duplicate files: ok file permissions: ok macro use: ok content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel dep: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok Summary: fix directory ownership, then it is good to go
(In reply to comment #2) > packaging guidelines: generally, ok. some minor cleanups possible: > - BuildRoot: is no longer needed > - rm -rf %{buildroot} in %install no longer needed > - %clean no longer needed all three removed > directory ownership: looks like you need to own > %{_datadir}/libwacom > %{_includedir}/libwacom-1.0 > %{_includedir}/libwacom-1.0/libwacom added to the devel/data packages as required. update spec/srpm available at URL above
Looks all good now. Approved
New Package SCM Request ======================= Package Name: libwacom Short Description: Tablet Information Client Library Owners: whot hadess Branches: f16 InitialCC:
Git done (by process-git-requests). Matthias, please take ownership of review BZs. Thanks!
libwacom-0.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libwacom-0.1-1.fc16
libwacom-0.1-1.fc16 has been pushed to the Fedora 16 stable repository.