Version: Custom vdsm rpm for setupNetworks: vdsm-4.9-3.0.1.ga16981.displayNetworkDan.x86_64 Steps to reproduce: 1. Create tagged network (network with vlan) on nic 2. Change the vlan number to 4095 (vlans' extended range) Results: 1. The operation failed 2. Wrong status code and message returned - the code and message says that the operations succeded 3. The roll-back didn't work - the nic was removed from the network 4. The was no validation for the vlan id so the operation failed on "RTNETLINK answers: Numerical result out of range" From vdsm.log: -------------- Thread-7723::DEBUG::2012-01-04 17:30:54,129::clientIF::54::vds::(wrapper) [10.35.97.56]::call setupNetworks with ({'vlan203': {'nic': 'eth1', 'vlan': '4095'}}, {}, {'connectivityCheck': 'false', 'connectivityTimeout': '60'}) {} MainProcess|Thread-7723::INFO::2012-01-04 17:30:54,159::configNetwork::790::setupNetworks::(setupNetworks) Setting up network MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:54,159::configNetwork::791::setupNetworks::(setupNetworks) Setting up network according to configuration: networks:{'vlan203': {'nic': 'eth1', 'vlan': '4095'}}, bondings:{}, options:{'connectivityCheck': 'false', 'connectivityTimeout': '60'} MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:54,160::configNetwork::795::root::(setupNetworks) Validating configuration MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:54,176::configNetwork::798::setupNetworks::(setupNetworks) Applying... MainProcess|Thread-7723::INFO::2012-01-04 17:30:54,192::configNetwork::518::root::(delNetwork) Removing bridge vlan203 with vlan=204, bonding=None, nics=['eth1']. options={} MainProcess|Thread-7723::WARNING::2012-01-04 17:30:54,779::configNetwork::61::root::(ifdown) MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:55,063::configNetwork::145::root::(_atomicBackup) Backed up /etc/sysconfig/network-scripts/ifcfg-eth1 MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:55,066::configNetwork::145::root::(_atomicBackup) Backed up /etc/sysconfig/network-scripts/ifcfg-eth1.204 MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:55,066::configNetwork::145::root::(_atomicBackup) Backed up /etc/sysconfig/network-scripts/ifcfg-vlan203 MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:55,106::configNetwork::820::setupNetworks::(setupNetworks) Adding network 'vlan203' MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:55,122::configNetwork::412::root::(addNetwork) validating bridge... MainProcess|Thread-7723::INFO::2012-01-04 17:30:55,123::configNetwork::417::root::(addNetwork) Adding bridge vlan203 with vlan=4095, bonding=None, nics=['eth1']. bondingOptions=None, options={} MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:55,124::configNetwork::191::root::(_persistentBackup) Persistently backed up /etc/sysconfig/network-scripts/ifcfg-eth1.4095 (until next 'set safe config') MainProcess|Thread-7723::DEBUG::2012-01-04 17:30:55,124::configNetwork::145::root::(_atomicBackup) Backed up /etc/sysconfig/network-scripts/ifcfg-eth1 MainProcess|Thread-7723::INFO::2012-01-04 17:30:55,654::configNetwork::70::root::(ifup) ERROR: could not add vlan 4095 as eth1.4095 on dev eth1 MainProcess|Thread-7723::WARNING::2012-01-04 17:30:55,655::configNetwork::72::root::(ifup) RTNETLINK answers: Numerical result out of range Thread-7723::DEBUG::2012-01-04 17:30:55,851::clientIF::59::vds::(wrapper) return setupNetworks with {'status': {'message': 'Done', 'code': 0}} Thread-7724::DEBUG::2012-01-04 17:30:55,862::clientIF::54::vds::(wrapper) [10.35.97.56]::call getVdsCapabilities with () {} Thread-7724::DEBUG::2012-01-04 17:30:55,889::utils::579::Storage.Misc.excCmd::(execCmd) '/bin/rpm -q --qf "%{NAME}\t%{VERSION}\t%{RELEASE}\t%{BUILDTIME}\n" qemu-kvm' (cwd None) Thread-7724::DEBUG::2012-01-04 17:30:55,928::utils::579::Storage.Misc.excCmd::(execCmd) SUCCESS: <err> = ''; <rc> = 0 Thread-7724::DEBUG::2012-01-04 17:30:55,935::utils::579::Storage.Misc.excCmd::(execCmd) '/bin/rpm -q --qf "%{NAME}\t%{VERSION}\t%{RELEASE}\t%{BUILDTIME}\n" qemu-img' (cwd None) Thread-7724::DEBUG::2012-01-04 17:30:55,971::utils::579::Storage.Misc.excCmd::(execCmd) SUCCESS: <err> = ''; <rc> = 0 Thread-7724::DEBUG::2012-01-04 17:30:55,973::utils::579::Storage.Misc.excCmd::(execCmd) '/bin/rpm -q --qf "%{NAME}\t%{VERSION}\t%{RELEASE}\t%{BUILDTIME}\n" vdsm' (cwd None) Thread-7724::DEBUG::2012-01-04 17:30:56,006::utils::579::Storage.Misc.excCmd::(execCmd) SUCCESS: <err> = ''; <rc> = 0 Thread-7724::DEBUG::2012-01-04 17:30:56,007::utils::579::Storage.Misc.excCmd::(execCmd) '/bin/rpm -q --qf "%{NAME}\t%{VERSION}\t%{RELEASE}\t%{BUILDTIME}\n" spice-server' (cwd None) Thread-7724::DEBUG::2012-01-04 17:30:56,041::utils::579::Storage.Misc.excCmd::(execCmd) SUCCESS: <err> = ''; <rc> = 0 Thread-7724::DEBUG::2012-01-04 17:30:56,042::utils::579::Storage.Misc.excCmd::(execCmd) '/bin/rpm -q --qf "%{NAME}\t%{VERSION}\t%{RELEASE}\t%{BUILDTIME}\n" libvirt' (cwd None) Thread-7724::DEBUG::2012-01-04 17:30:56,076::utils::579::Storage.Misc.excCmd::(execCmd) SUCCESS: <err> = ''; <rc> = 0 Thread-7724::DEBUG::2012-01-04 17:30:56,079::clientIF::59::vds::(wrapper) return getVdsCapabilities with {'status': {'message': 'Done', 'code': 0}, 'info': {'HBAInventory': {'iSCSI': [{'InitiatorName': 'iqn.1994-05.com.redhat:695e8a3d5cf1'}], 'FC': []}, 'packages2': {'kernel': {'release': '220.el6.x86_64', 'buildtime': 1320818593.0, 'version': '2.6.32'}, 'spice-server': {'release': '5.el6', 'buildtime': '1319663438', 'version': '0.8.2'}, 'vdsm': {'release': '3.0.1.ga16981.displayNetworkDan', 'buildtime': '1324198085', 'version': '4.9'}, 'qemu-kvm': {'release': '2.210.el6', 'buildtime': '1322042178', 'version': '0.12.1.2'}, 'libvirt': {'release': '23.el6', 'buildtime': '1320806439', 'version': '0.9.4'}, 'qemu-img': {'release': '2.210.el6', 'buildtime': '1322042178', 'version': '0.12.1.2'}}, 'cpuModel': 'Quad-Core AMD Opteron(tm) Processor 2350', 'hooks': {}, 'vmTypes': ['kvm'], 'supportedProtocols': ['2.2', '2.3'], 'networks': {'engine': {'addr': '10.35.110.13', 'cfg': {'IPADDR': '10.35.110.13', 'GATEWAY': '10.35.110.254', 'DELAY': '0', 'NM_CONTROLLED': 'yes', 'NETMASK': '255.255.255.0', 'BOOTPROTO': 'static', 'DEVICE': 'engine', 'TYPE': 'Bridge', 'ONBOOT': 'yes'}, 'ports': ['eth0'], 'netmask': '255.255.255.0', 'stp': 'off', 'gateway': '10.35.110.254'}, 'vlan203': {'addr': '', 'cfg': {'DEVICE': 'vlan203', 'DELAY': '0', 'TYPE': 'Bridge', 'ONBOOT': 'yes'}, 'ports': [], 'netmask': '', 'stp': 'off', 'gateway': '0.0.0.0'}}, 'uuid': '44454C4C-5400-1056-8034-B4C04F53334A_00:1!E:C9:4A:39:2A', 'lastClientIface': 'engine', 'nics': {'eth1': {'hwaddr': '00:1E:C9:4A:39:2B', 'netmask': '', 'speed': 1000, 'addr': ''}, 'eth0': {'hwaddr': '00:1E:C9:4A:39:2A', 'netmask': '', 'speed': 1000, 'addr': ''}}, 'software_revision': '3.0', 'management_ip': '', 'clusterLevels': ['3.0'], 'cpuFlags': u'fpu,vme,de,pse,tsc,msr,pae,mce,cx8,apic,mtrr,pge,mca,cmov,pat,pse36,clflush,mmx,fxsr,sse,sse2,ht,syscall,nx,mmxext,fxsr_opt,pdpe1gb,rdtscp,lm,3dnowext,3dnow,constant_tsc,rep_good,nonstop_tsc,extd_apicid,pni,monitor,cx16,popcnt,lahf_lm,cmp_legacy,svm,extapic,cr8_legacy,abm,sse4a,misalignsse,3dnowprefetch,osvw,ibs,npt,lbrv,svm_lock,model_486,model_pentium,model_pentium2,model_pentium3,model_pentiumpro,model_qemu32,model_coreduo,model_qemu64,model_phenom,model_athlon,model_Opteron_G1,model_Opteron_G2,model_Opteron_G3', 'ISCSIInitiatorName': 'iqn.1994-05.com.redhat:695e8a3d5cf1', 'memSize': '7933', 'reservedMem': '256', 'bondings': {'bond4': {'hwaddr': '00:00:00:00:00:00', 'cfg': {}, 'netmask': '', 'addr': '', 'slaves': []}, 'bond0': {'hwaddr': '00:00:00:00:00:00', 'cfg': {}, 'netmask': '', 'addr': '', 'slaves': []}, 'bond1': {'hwaddr': '00:00:00:00:00:00', 'cfg': {}, 'netmask': '', 'addr': '', 'slaves': []}, 'bond2': {'hwaddr': '00:00:00:00:00:00', 'cfg': {}, 'netmask': '', 'addr': '', 'slaves': []}, 'bond3': {'hwaddr': '00:00:00:00:00:00', 'cfg': {}, 'netmask': '', 'addr': '', 'slaves': []}}, 'software_version': '4.9', 'cpuSpeed': '1994.985', 'cpuSockets': '2', 'vlans': {}, 'cpuCores': '8', 'kvmEnabled': 'true', 'guestOverhead': '65', 'supportedRHEVMs': ['3.0'], 'version_name': 'Snow Man', 'emulatedMachines': [u'rhel6.2.0', u'pc', u'rhel6.1.0', u'rhel6.0.0', u'rhel5.5.0', u'rhel5.4.4', u'rhel5.4.0'], 'operatingSystem': {'release': '6.2.0.3.el6', 'version': '6Server', 'name': 'RHEL'}, 'lastClient': '10.35.97.56'}} The sended request: DEBUG:suds.client:sending to (http://camel-upstream.qa.lab.tlv.redhat.com:8080/engine-engine-genericapi/GenericApiService) message: <?xml version="1.0" encoding="UTF-8"?> <SOAP-ENV:Envelope xmlns:wsa="http://www.w3.org/2005/08/addressing" xmlns:ns0="http://service.engine.ovirt.org" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ns1="http://schemas.xmlsoap.org/soap/envelope/" xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"> <SOAP-ENV:Header> <wsa:Action>Login</wsa:Action> </SOAP-ENV:Header> <ns1:Body> <ns0:Login> <arg0> <ParentCommand/> <MultipleAction/> <TaskStartTime/> <userName>***</userName> <userPassword>***</userPassword> <domain>internal</domain> <ActionType>LoginAdminUser</ActionType> <IsAdmin/> <actionType>LoginAdminUser</actionType> </arg0> </ns0:Login> </ns1:Body> </SOAP-ENV:Envelope> DEBUG:suds.client:headers = {'SOAPAction': '""', 'Content-Type': 'text/xml; charset=utf-8'} ########################### 255.255.255.0 DEBUG:suds.client:http succeeded: <env:Envelope xmlns:env='http://www.w3.org/2003/05/soap-envelope'><env:Header xmlns:wsa='http://www.w3.org/2005/08/addressing'><wsa:To>http://www.w3.org/2005/08/addressing/anonymous</wsa:To><wsa:Action>http://service.engine.ovirt.org/IBackendCxfPort/LoginResponse</wsa:Action></env:Header><env:Body><ns2:LoginResponse xmlns:ns2="http://service.engine.ovirt.org"><return xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="ns2:VdcLoginReturnValueBase"><ActionReturnValue xsi:type="ns2:VdcUser"><UserId><uuid>fdfc627c-d875-11e0-90f0-83df133b58cc</uuid></UserId><UserName>admin@internal</UserName><DomainControler>internal</DomainControler><FirstName>admin</FirstName></ActionReturnValue><CanDoAction>true</CanDoAction><Description></Description><IsSynchronous>true</IsSynchronous><Succeeded>true</Succeeded><LoginResult>Autheticated</LoginResult></return></ns2:LoginResponse></env:Body></env:Envelope> [31m (SetupNetworksParameters){ HttpSessionId = None ParametersCurrentUser = (VdcUser){ UserId = (guid){ uuid = None } UserName = None Password = None DomainControler = None Browser = None FirstName = None SurName = None } ParentCommand = (VdcActionType){ value = None } MultipleAction = None TaskStartTime = None privateTaskIds[] = <empty> SessionId = None VdsId = (guid){ uuid = "11888324-24bc-11e1-ab16-73e01c9d7446" } Networks[] = (network){ Id = (guid){ uuid = 10d27d2e-36e9-11e1-974d-f0def1376f23 } name = "vlan203" description = None type = None addr = "203.1.1.1" subnet = "255.255.255.0" gateway = False vlan_id = "4095" stp = False storage_pool_id = "8edd9e41-18ed-47dd-aaf4-e63afddeef37" Status = (NetworkStatus){ value = None } is_display = False }, RemovedNetworks[] = <empty> Bonds[] = <empty> RemovedBonds[] = <empty> Interfaces[] = (VdsNetworkInterface){ Id = (guid){ uuid = None } Name = "eth1" MacAddress = None NetworkName = "vlan203" Type = None Speed = None Statistics = (NetworkStatistics){ Id = (guid){ uuid = None } Status = DEBUG:suds.client:sending to (http://camel-upstream.qa.lab.tlv.redhat.com:8080/engine-engine-genericapi/GenericApiService) (InterfaceStatus){ value = None } ReceiveDropRate = None ReceiveRate = None TransmitDropRate = None TransmitRate = None } VdsId = "11888324-24bc-11e1-ab16-73e01c9d7446" VdsName = None BootProtocol = "None" Address = None Subnet = None Gateway = None VlanId = None Bonded = False BondName = None BondType = None BondOptions = None IsManagement = False }, Force = False CheckConnectivity = False ConnectivityTimeout = 60 } [0m message: <?xml version="1.0" encoding="UTF-8"?> <SOAP-ENV:Envelope xmlns:wsa="http://www.w3.org/2005/08/addressing" xmlns:ns0="http://service.engine.ovirt.org" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ns1="http://schemas.xmlsoap.org/soap/envelope/" xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"> <SOAP-ENV:Header> <wsa:Action>Login</wsa:Action> </SOAP-ENV:Header> <ns1:Body> <ns0:RunAction> <arg0>SetupNetworks</arg0> <arg1 xsi:type="SetupNetworksParameters"> <ParentCommand/> <MultipleAction/> <TaskStartTime/> <VdsId> <uuid>11888324-24bc-11e1-ab16-73e01c9d7446</uuid> </VdsId> <Networks> <Id> <uuid>10d27d2e-36e9-11e1-974d-f0def1376f23</uuid> </Id> <name>vlan203</name> <addr>203.1.1.1</addr> <subnet>255.255.255.0</subnet> <gateway>False</gateway> <vlan_id>4095</vlan_id> <stp>false</stp> <storage_pool_id>8edd9e41-18ed-47dd-aaf4-e63afddeef37</storage_pool_id> <Status/> <is_display>false</is_display> </Networks> <Interfaces> <Name>eth1</Name> <NetworkName>vlan203</NetworkName> <VdsId>11888324-24bc-11e1-ab16-73e01c9d7446</VdsId> <BootProtocol>None</BootProtocol> <Bonded>false</Bonded> <IsManagement>false</IsManagement> </Interfaces> <Force>false</Force> <CheckConnectivity>false</CheckConnectivity> <ConnectivityTimeout>60</ConnectivityTimeout> </arg1> </ns0:RunAction> </ns1:Body> </SOAP-ENV:Envelope> DEBUG:suds.client:headers = {'SOAPAction': '""', 'Content-Type': 'text/xml; charset=utf-8'} DEBUG:suds.client:http succeeded: <env:Envelope xmlns:env='http://www.w3.org/2003/05/soap-envelope'><env:Header xmlns:wsa='http://www.w3.org/2005/08/addressing'><wsa:To>http://www.w3.org/2005/08/addressing/anonymous</wsa:To><wsa:Action>http://service.engine.ovirt.org/IBackendCxfPort/RunActionResponse</wsa:Action></env:Header><env:Body><ns2:RunActionResponse xmlns:ns2="http://service.engine.ovirt.org"><return><CanDoAction>true</CanDoAction><Description>blond-vdsd</Description><IsSynchronous>true</IsSynchronous><Succeeded>true</Succeeded></return></ns2:RunActionResponse></env:Body></env:Envelope>
http://gerrit.ovirt.org/1033
In the ovirt-3.1 branch as: 1d7b929e99d04c2795a2cb8b1d24ffd581add8b8
closing ON_QA bugs as oVirt 3.1 was released: http://www.ovirt.org/get-ovirt/