Bug 784945 - Review Request: ktp-common-internals - Common internals for KDE Telepathy
Summary: Review Request: ktp-common-internals - Common internals for KDE Telepathy
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 784941
Blocks: kde-reviews kde-telepathy-0.3 784944 784946 784949 784950 784951 784952 784954 784955 784956 784958
TreeView+ depends on / blocked
 
Reported: 2012-01-26 18:38 UTC by Rex Dieter
Modified: 2012-02-09 18:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-09 18:42:52 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2012-01-26 18:38:19 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-common-internals.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-common-internals-0.3.0-1.fc16.src.rpm
Description: Common internals for KDE Telepathy
Comment 1 nucleo 2012-02-07 01:20:30 UTC 
name: ok
summary: ok
license: ok
BuildRequires: ok
devel requires main package; ok
handling locale files: ok
/sbin/ldconfig in %post/%postun: ok

The only issue is unneeded commented lines:
#{_kde4_datadir}/kde4/services/kcm_telepathy_accounts.desktop
#{_kde4_datadir}/kde4/servicetypes/kcmtelepathyaccounts-accountuiplugin.desktop
#{_kde4_datadir}/kde4/services/kcmtelepathyaccounts_plugin_sunshine.desktop
#{_kde4_libdir}/kde4/kcmtelepathyaccounts_plugin_butterfly.so

Please remove them before commit.

APPROVED.
Comment 2 nucleo 2012-02-07 01:23:55 UTC 
Forgot rpmlint output is ok:
ktp-common-internals-devel.i686: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.
Comment 3 Rex Dieter 2012-02-07 13:46:51 UTC 
New Package SCM Request
=======================
Package Name: ktp-common-internals
Short Description: Common internals for KDE Telepathy
Owners: jreznik rdieter
Branches: f16
Comment 4 Gwyn Ciesla 2012-02-07 13:51:15 UTC 
Git done (by process-git-requests).
Comment 5 Rex Dieter 2012-02-09 18:42:52 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.