Spec URL: http://magcius.mecheye.net/gnome/gnome-initial-setup.spec SRPM URL: http://magcius.mecheye.net/gnome/gnome-initial-setup-0.1-1.fc17.src.rpm Description: firstboot, but in GNOME, and integrated and stuff, man Fedora Account System Username: magcius
If this is the replacement of firstboot then this package should obsolete/provide firstboot right?
Not quite. There are external firstboot plugins that have to work without modification, so we're looking into firstboot integration with something like XEmbed
We are not replacing firstboot entirely here, at least not in F18, so an obsoletes is not appropriate.
Thanks for the reply.
I've updated the specfile to update to the 0.2 release.
[rishi@kolache SPECS]$ rpmlint gnome-initial-setup.spec gnome-initial-setup.spec:52: W: macro-in-comment %{buildroot} gnome-initial-setup.spec:52: W: macro-in-comment %{_sysconfdir} 0 packages and 1 specfiles checked; 0 errors, 2 warnings. [rishi@kolache SPECS]$ rpmlint ../SRPMS/gnome-initial-setup-0.2-1.fc18.src.rpm gnome-initial-setup.src: W: spelling-error %description -l en_US firstboot -> first boot, first-boot, firstborn gnome-initial-setup.src:52: W: macro-in-comment %{buildroot} gnome-initial-setup.src:52: W: macro-in-comment %{_sysconfdir} 1 packages and 0 specfiles checked; 0 errors, 3 warnings. The pedantic way is to use an extra % with the RPM macros. eg., %{buildroot} and %{_sysconfdir}. The spelling mistake is a false alarm. [rishi@kolache SPECS]$ rpmlint /home/rishi/devel/rpmbuild/RPMS/x86_64/gnome-initial-setup-0.2-1.fc18.x86_64.rpm gnome-initial-setup.x86_64: W: spelling-error %description -l en_US firstboot -> first boot, first-boot, firstborn Ditto. gnome-initial-setup.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/welcome-tour.desktop gnome-initial-setup.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/gnome-initial-setup-copy-worker.desktop Can be ignored, I think. gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/ar/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/as/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/el/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/he/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/hi/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/id/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/lt/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/lv/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/nb/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/pa/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/sl/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/sr/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/sr@latin/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/tr/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/vi/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/zh_HK/LC_MESSAGES/gnome-initial-setup.mo gnome-initial-setup.x86_64: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/gnome-initial-setup.mo 1 packages and 0 specfiles checked; 0 errors, 28 warnings. Use %find_lang. See: https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files [rishi@kolache SPECS]$ rpmlint /home/rishi/devel/rpmbuild/RPMS/x86_64/gnome-initial-setup-debuginfo-0.2-1.fc18.x86_64.rpm gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant-clutter.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/cc-common-language.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant-private.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-utils.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-photo-dialog.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/cc-common-language.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/cc-timezone-map.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-utils.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/cc-timezone-map.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/gdm-languages.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/gdm-languages.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/pw-utils.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/um-photo-dialog.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/tz.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/gis-assistant-gtk.c gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/location/tz.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/language/locarchive.h gnome-initial-setup-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-initial-setup-0.2/gnome-initial-setup/pages/account/pw-utils-pwquality.c 1 packages and 0 specfiles checked; 19 errors, 0 warnings. These have now been fixed upstream.
- package meets naming guidelines - package meets packaging guidelines use %global instead of %define - license GPLv2+ but in some cases the copyright headers are GPLv3+, but this has been fixed upstream COPYING should be in %doc - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - missing BR: desktop-file-utils, intltool, pkgconfig(iso-codes) - no unnecessary BR - locales, but does not use %find_lang - not relocatable - does not own all directories, %{_datadir}/gnome-initial-setup %{_datadir}/gnome-session/sessions %{_datadir}/polkit-1/actions - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop files validate
Here is a Spec with most of the fixes: http://rishi.fedorapeople.org/gnome-initial-setup.spec It just needs to be decided if gnome-initial-setup has a runtime dependency on gnome-session and polkit. If it does, they need to be in Requires, else it should own %{_datadir}/polkit-1/actions and %{_datadir}/gnome-session/sessions
(In reply to comment #5) > I've updated the specfile to update to the 0.2 release. Could you please also provide an updated srpm?
(In reply to comment #8) > > It just needs to be decided if gnome-initial-setup has a runtime dependency > on gnome-session and polkit. A runtime dep on gdm would probably be more to the point, and should bring gnome-session and polkit along.
New spec file / srpm (with Requires:gdm) here: http://mclasen.fedorapeople.org/gnome-initial-setup.spec http://mclasen.fedorapeople.org/gnome-initial-setup-0.2-2.fc18.src.rpm
+----------+ | APPROVED | +----------+
New Package SCM Request ======================= Package Name: gnome-initial-setup Short Description: configure your desktop Owners: magcius mclasen halfline Branches: InitialCC:
Git done (by process-git-requests). halfline is not a valid FAS account and can be added later.
Are we not planning to ship this package for f18? f18 has already been branched. so it won't be there if you aren't requesting. just wondering.
We are not shipping gnome-initial-setup in F18.
no plans even to build this in f19 also? as SCM is already done, at least this package can be built for f19.
It is going to be shipped in f19, which is the master branch. I didn't think I had to explicitly specify that.
I already checkout master branch and can see spec file. What I was asking is this $ koji latest-pkg f19 gnome-initial-setup Build Tag Built by ---------------------------------------- -------------------- ---------------- No builds on koji. Is this intentional?
That's because I haven't built it yet. I'll make builds available tomorrow.
Can we close this now?
hmm still not built on koji. also, status of this review must be assigned.
This can be closed as I see package is now available in f19.