983743 – external origin conversion attempt with reversed "-T" and "--thinpool" flag causes issues

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 983743 - external origin conversion attempt with reversed "-T" and "--thinpool" flag causes issues

Summary: external origin conversion attempt with reversed "-T" and "--thinpool" flag c...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	lvm2
Sub Component:
Version:	7.0
Hardware:	x86_64
OS:	Linux
Priority:	unspecified
Severity:	high
Target Milestone:	rc
Target Release:	---
Assignee:	LVM and device-mapper development team
QA Contact:	cluster-qe@redhat.com
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2013-07-11 20:40 UTC by Corey Marthaler
Modified:	2021-09-08 20:32 UTC (History)
CC List:	8 users (show)
Fixed In Version:	lvm2-2.02.102-1.el7
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2014-06-13 11:22:32 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Description Corey Marthaler 2013-07-11 20:40:18 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Corey Marthaler 2013-07-11 20:43:01 UTC

While playing with all the possible flag scenarios, I ran across this issue:

# Proper way to convert an external origin volume
[root@qalvm-01 ~]# lvconvert --thinpool VG/POOL --originname extorigin1 -T origin1
  Logical volume "extorigin1" created

# Improper way to convert
[root@qalvm-01 ~]# lvconvert -T VG/POOL --originname extorigin3 --thinpool origin3
  Logical volume "origin3_tmeta" created
  origin3_tdata is expected to have only one segment using it, while it has 3
  Failed to find pool_seg for origin3_tdata
  LV origin3_tdata: segment 1 pool data LV does not point back to same LV
  Internal error: LV segments corrupted in origin3_tdata.
  origin3_tdata is expected to have only one segment using it, while it has 3
  Failed to find pool_seg for origin3_tdata
  LV POOL: thin pool segment 1 data LV does not refer back to pool LV
  Internal error: LV segments corrupted in POOL.


3.10.0-0.rc5.61.el7.x86_64

lvm2-2.02.99-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013
lvm2-libs-2.02.99-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013
lvm2-cluster-2.02.99-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013
device-mapper-1.02.78-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013
device-mapper-libs-1.02.78-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013
device-mapper-event-1.02.78-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013
device-mapper-event-libs-1.02.78-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013
cmirror-2.02.99-0.79.el7    BUILT: Mon Jul  8 08:28:24 CDT 2013

Comment 3 Corey Marthaler 2013-07-15 21:01:27 UTC

same issue w/ reversed --thin and --thinpool:

lvconvert --thin snapper_thinp/POOL --originname extorigin5 --thinpool origin5  origin5_tdata is expected to have only one segment using it, while it has 3
  Failed to find pool_seg for origin5_tdata
  LV origin5_tdata: segment 1 pool data LV does not point back to same LV
  Internal error: LV segments corrupted in origin5_tdata.
  origin5_tdata is expected to have only one segment using it, while it has 3
  Failed to find pool_seg for origin5_tdata
  LV POOL: thin pool segment 1 data LV does not refer back to pool LV
  Internal error: LV segments corrupted in POOL.

Comment 4 Zdenek Kabelac 2013-08-08 10:10:40 UTC

Yep internal error is a bug a needs fix - tool needs to report it doesn't support thinpool to be read-only external origin.

But just clarifying here --thin  and  -T   are equal  (T is shortcut for thin)
So comment 3 and comment 1 are the same issue.

Comment 5 Zdenek Kabelac 2013-08-09 21:22:05 UTC

Prohibited conversion of thin pool to external origin:

https://www.redhat.com/archives/lvm-devel/2013-August/msg00036.html

Comment 8 Corey Marthaler 2014-01-27 18:35:10 UTC

Fix verified in the latest rhel7 rpms.

lvm2-2.02.105-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014
lvm2-libs-2.02.105-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014
lvm2-cluster-2.02.105-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014
device-mapper-1.02.84-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014
device-mapper-libs-1.02.84-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014
device-mapper-event-1.02.84-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014
device-mapper-event-libs-1.02.84-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014
device-mapper-persistent-data-0.2.8-3.el7    BUILT: Fri Dec 27 13:40:56 CST 2013
cmirror-2.02.105-1.el7    BUILT: Wed Jan 22 07:34:15 CST 2014


[root@host-050 ~]# lvconvert -T snapper_thinp/POOL --originname extorigin4 --thinpool origin4
  Can't convert pool "snapper_thinp/origin4" to external origin.
[root@host-050 ~]# lvconvert --thin snapper_thinp/POOL --originname extorigin5 --thinpool origin5
  Can't convert pool "snapper_thinp/origin5" to external origin.

Comment 9 Ludek Smid 2014-06-13 11:22:32 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.

Note You need to log in before you can comment on or make changes to this bug.