Bug 604031
Summary: | Review Request: kde-plasma-kprayertime - Displays Islamic prayer Time | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mohammed Imran <imranceh> |
Component: | Package Review | Assignee: | Volker Fröhlich <volker27> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, rdieter, volker27 |
Target Milestone: | --- | Flags: | volker27:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | StalledSubmitter | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-04-15 19:29:40 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mohammed Imran
2010-06-15 08:41:46 UTC
* rpmlint clean * sources: OK $ md5sum kprayertime4.01.src.tar.gz 098682e4b6c6b5b1f5caf68f4d3ca412 kprayertime4.01.src.tar.gz * license ok * builds on F13, F14 and Rawhide * installs/runs ok * files ok I'm not really sure, if upstream calls it kde-plasma-kprayertime or kde-plasma-kprayertime4. I think it is prefered to write "BuildRequires: cmake gettext" instead of "BuildRequires: cmake,gettext". Your package doesn't seem to need gettext, since no translations are included. I think the description should end with a period. The capitalization of "Islamic Prayer time" is also different for the description and the summary. You may have to add these two lines, since your package introduces a shared library. %post -p /sbin/ldconfig %postun -p /sbin/ldconfig Just a note that the .so file is not in the regular library path and calling ldconfig is superfluous. See http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries: " In addition, every binary RPM package which contains shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig [...] " Are you still interested in packaging this? Re-open if necessary. |