Red Hat Bugzilla – Bug 604031
Review Request: kde-plasma-kprayertime - Displays Islamic prayer Time
Last modified: 2011-12-08 13:18:19 EST
Spec URL: http://github.com/downloads/matriux/fedora/kde-plasma-kprayertime.spec
SRPM URL: http://github.com/downloads/matriux/fedora/kde-plasma-kprayertime-4.01-1.fc12.src.rpm
Plasmoid to display Islamic Prayer time
[imran@localhost SPECS]$ rpmlint kde-plasma-kprayertime.spec ../SRPMS/kde-plasma-kprayertime-4.01-1.fc12.src.rpm ../RPMS/i686/kde-plasma-kprayertime-4.01-1.fc12.i686.rpm
kde-plasma-kprayertime.src: W: spelling-error %description -l en_US Plasmoid -> Plasma, Plastic, Plasticine
kde-plasma-kprayertime.i686: W: spelling-error %description -l en_US Plasmoid -> Plasma, Plastic, Plasticine
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
* rpmlint clean
* sources: OK
$ md5sum kprayertime4.01.src.tar.gz
* license ok
* builds on F13, F14 and Rawhide
* installs/runs ok
* files ok
I'm not really sure, if upstream calls it kde-plasma-kprayertime or kde-plasma-kprayertime4.
I think it is prefered to write "BuildRequires: cmake gettext" instead of "BuildRequires: cmake,gettext". Your package doesn't seem to need gettext, since no translations are included.
I think the description should end with a period. The capitalization of "Islamic Prayer time" is also different for the description and the summary.
You may have to add these two lines, since your package introduces a shared library.
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
Just a note that the .so file is not in the regular library path and calling ldconfig is superfluous.
In addition, every binary RPM package which contains shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig [...]
Are you still interested in packaging this?
Re-open if necessary.