Bug 1000777

Summary:	assertion should not be enabled in RPM
Product:	[Fedora] Fedora	Reporter:	Remi Collet <fedora>
Component:	leveldb	Assignee:	Peter Lemenkov <lemenkov>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	lemenkov, puntogil
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	leveldb-1.12.0-5.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-27 23:28:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Remi Collet 2013-08-25 07:01:03 UTC

Upstream Makefile suggest to use following build option

OPT ?= -O2 -DNDEBUG       # (A) Production use (optimized mode)
# OPT ?= -g2              # (B) Debug mode, w/ full line-level debugging symbols
# OPT ?= -O2 -g2 -DNDEBUG # (C) Profiling mode: opt, but w/debugging symbols


In Fedora RPM, of course standard build options are used, BUT without -DNDEBUG, so assert are enable.

Using this seem to solve this issue
  export CFLAGS="$RPM_OPT_FLAGS -DNDEBUG"
  export CXXFLAGS="$RPM_OPT_FLAGS -DNDEBUG"

Note this should also fix bug #908800

I discover this working on the PHP connector for leveldb (php-pecl-leveldb) which raises a lot of assert during test suite.

Tested with leveldb 1.13.0 (released a few days ago), -DNDEBUG seems ok.

Comment 1 Peter Lemenkov 2013-08-25 07:21:31 UTC

Thanks for the report - I'll fix it shortly.

Regarding update to 1.13 - that's more complicated since I have to check compatibility with few other apps dependent on leveldb.

Comment 2 Fedora Update System 2013-08-26 04:33:17 UTC

leveldb-1.12.0-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/leveldb-1.12.0-5.fc19

Comment 3 Fedora Update System 2013-08-26 22:29:46 UTC

Package leveldb-1.12.0-5.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing leveldb-1.12.0-5.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-15327/leveldb-1.12.0-5.fc19
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-08-27 23:28:54 UTC

leveldb-1.12.0-5.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.