Bug 1001243

Looks like an easy fix. Removing from tracker ticket, since the docdir is non-versioned, and there are several other packaging issues:


* package -doc sets wrong Group tag, should be "Documentation

* package -doc should not require "kicad", so the documentation can be installed and viewed independently

* none of the -doc-XX subpackages for non-English languages should depend on the -doc package. If that has been done only for directory ownership, please notice
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

in other words, you may add a "%dir %{_docdir}/%{name}" entry to each -doc-XX package instead of depending on the -doc package

* BuildRoot definition, emptying and the %clean section are not needed anymore, not for EL6 either
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

* package "kicad" executes ldconfig in scriptlets. Why? It doesn't install any shared libs in run-time linker's search path. And for the extended search path that adds %_libdir/kicad/, ldconfig doesn't need to be called, because the dir is empty. 

* %defattr is not needed anymore for any of the active dist releases including EL5+6
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

* files below %_docdir are marked as documentation automatically, no need to use %doc for such paths

* why does the base package duplicate %{_docdir}/%{name}/help/en/kicad.pdf? If that file is a hard requirement, it must not be stored in docdir, since RPM may be configured to --excludedocs. a file that MUST be available at run-time would need to be stored elsewhere and not below /usr/share/doc

(In reply to Michael Schwendt from comment #1)
> Looks like an easy fix. Removing from tracker ticket, since the docdir is
> non-versioned, and there are several other packaging issues:
> 
> 
> * package -doc sets wrong Group tag, should be "Documentation

Fixed.

> * package -doc should not require "kicad", so the documentation can be
> installed and viewed independently

I don't agree, but fixed.

> * none of the -doc-XX subpackages for non-English languages should depend on
> the -doc package. If that has been done only for directory ownership, please
> notice
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your
> _package_to_function
> 
> in other words, you may add a "%dir %{_docdir}/%{name}" entry to each
> -doc-XX package instead of depending on the -doc package

doc-XX depends on doc because translations are poor
Won't fix.

> * BuildRoot definition, emptying and the %clean section are not needed
> anymore, not for EL6 either
> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
> https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

Fixed.

> * package "kicad" executes ldconfig in scriptlets. Why? It doesn't install
> any shared libs in run-time linker's search path. And for the extended
> search path that adds %_libdir/kicad/, ldconfig doesn't need to be called,
> because the dir is empty. 

Fixed.

> * %defattr is not needed anymore for any of the active dist releases
> including EL5+6
> https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

Fixed.

> * files below %_docdir are marked as documentation automatically, no need to
> use %doc for such paths

Fixed.

> * why does the base package duplicate %{_docdir}/%{name}/help/en/kicad.pdf?
> If that file is a hard requirement, it must not be stored in docdir, since
> RPM may be configured to --excludedocs. a file that MUST be available at
> run-time would need to be stored elsewhere and not below /usr/share/doc

Fixed.

Thanks for this review ;-)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6329086
http://koji.fedoraproject.org/koji/taskinfo?taskID=6329106

kicad-2013.06.11-4.rev4021.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kicad-2013.06.11-4.rev4021.fc20

Package kicad-2013.06.11-4.rev4021.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing kicad-2013.06.11-4.rev4021.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-23944/kicad-2013.06.11-4.rev4021.fc20
then log in and leave karma (feedback).

kicad-2013.06.11-4.rev4021.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.