Bug 1002490

Summary: virsh cpu-baseline doesn't print error message for empty file argument
Product: Red Hat Enterprise Linux 6 Reporter: Pavel Hrdina <phrdina>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED DUPLICATE QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.5CC: acathrow, dyuan, gsun, honzhang, jdenemar, pkrempa
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-04 13:41:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Hrdina 2013-08-29 10:19:01 UTC
Description of problem:
The virsh command 'cpu-baseline' doesn't print eny error message into stderr for emtpy file argument. This bug has been discovered by libvirt-autotest.

Version-Release number of selected component (if applicable):
libvirt-0.10.2-23.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. virsh cpu-baseline ''

Actual results:
echo $? -> 1
stderr -> nothing

Expected results:
echo $? -> 1
stderr -> error: Failed to get option 'file': Option argument is empty

Additional info:
The error message is from upstream libvirt.

Comment 1 Peter Krempa 2013-08-29 10:26:34 UTC
This was fixed upstream by commit:

commit fa956d9055c6fc1aaf672172343172da113f5e47
Author: Peter Krempa <pkrempa>
Date:   Mon Jan 21 15:39:18 2013 +0100

    virsh-domain: Update domain commands to use vshCommandOptStringReq

Comment 4 Jiri Denemark 2013-09-04 13:41:44 UTC

*** This bug has been marked as a duplicate of bug 889276 ***