Bug 1002690

It actually does not depend only on the UP vs WA but also on the fact if the spice driver is installed on the VM or not.

The logic is:
- for WA always send 1
- for UP send 1 if the spice driver is not installed and 0 if the spice driver is installed.

@Marian: does it behave this way?

(In reply to Tomas Jelinek from comment #1)
> It actually does not depend only on the UP vs WA but also on the fact if the
> spice driver is installed on the VM or not.
> 
> The logic is:
> - for WA always send 1
> - for UP send 1 if the spice driver is not installed and 0 if the spice
> driver is installed.
> 
> @Marian: does it behave this way?

Yes, It seems It does, so The beahviour depends on RHEV agent whether It reports correctly that qxl driver is installed or not, I am pretty sure The driver was installed jut it might not to be reported correctly.
In Any case let me slightly change the bug description:
Once "native client" launch method is used, AdminConsole parameter is missed in vv file returned by User portal (I am just seeing unexpected behaviour after launch of Windows VM, so I am trying to figure out the problem, I thought It was wrong value but as I am looking at vv files There is actually no value).

this functionality is implemented in spice-xpi plugin itself(and supposedly activex) and is missing in virt-viewer .vv file processing. It would need to be added there, then we can add it to .vv

Maybe we should revisit the name of the property as the underlying property is "auto resolution" and that has nothing to do with "admin console".
Any other issue than difference in auto resolution setting, Marian?

Marc-Andre, I suppose we have to add some new parameter in any case

(In reply to Michal Skrivanek from comment #3)
> this functionality is implemented in spice-xpi plugin itself(and supposedly
> activex) and is missing in virt-viewer .vv file processing. It would need to
> be added there, then we can add it to .vv
> 
> Maybe we should revisit the name of the property as the underlying property
> is "auto resolution" and that has nothing to do with "admin console".
> Any other issue than difference in auto resolution setting, Marian?
I am not aware of any other. Maybe we had some in past but not any more.
> 
> Marc-Andre, I suppose we have to add some new parameter in any case

(In reply to Michal Skrivanek from comment #3)
> Marc-Andre, I suppose we have to add some new parameter in any case

Currently, the .vv "fullscreen" key is an int of value 0 or 1. We can add value 2 for what is called "fullscreen-auto-conf" in virt-viewer. Should I open a bug?

yes, please. I wasn't sure about component...maybe we need a new one?

so does "2" cover all scenarios? We sent fullscreen and admin console separately but we're not sure about what it actually does

well, this is in xpi:
SendValue(CONTROLLER_FULL_SCREEN,
     (m_fullscreen == PR_TRUE ? CONTROLLER_SET_FULL_SCREEN : 0) |
     (m_admin_console == PR_FALSE ? CONTROLLER_AUTO_DISPLAY_RES : 0));

(In reply to Michal Skrivanek from comment #7)
> yes, please. I wasn't sure about component...maybe we need a new one?
> 
> so does "2" cover all scenarios? We sent fullscreen and admin console
> separately but we're not sure about what it actually does
> 
> well, this is in xpi:
> SendValue(CONTROLLER_FULL_SCREEN,
>      (m_fullscreen == PR_TRUE ? CONTROLLER_SET_FULL_SCREEN : 0) |
>      (m_admin_console == PR_FALSE ? CONTROLLER_AUTO_DISPLAY_RES : 0));

remote-viewer doesn't support auto-res without going fullscreen. 

(it is probably not a desirable behaviour, you would end up with n-monitors large windows on the current monitor).

then indeed value of 2 would work. Please open a corresponding virt-viewer bug

@Marc-Andre did you open the corresponding virt-viewer bug? I somehow can not find it...

I don't see what bug we are talking about..

You need to send both flags if you want fullscreen & autores. (ie, they are flags, not enums)

I think the one from comment #6, something we can put into the .vv file and covers all 3 cases(combinations of fullscreen&autores)

(In reply to Michal Skrivanek from comment #12)
> I think the one from comment #6, something we can put into the .vv file and
> covers all 3 cases(combinations of fullscreen&autores)

ok, vv support is missing that auto-res flag.

But in upstream the autores flag has been removed, see also bug 1027381.

Kinda stink to add a feature to remove right after.
.

makes sense

*** This bug has been marked as a duplicate of bug 1027381 ***