Bug 1027381 - [RFE] Deprecate "basic fullscreen" mode
[RFE] Deprecate "basic fullscreen" mode
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: RFEs (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: 3.5.0
Assigned To: Frantisek Kobzik
: FutureFeature, Improvement, Reopened, Triaged
: 1002690 (view as bug list)
Depends On:
Blocks: 1032960 rhev3.5beta 1156165
  Show dependency treegraph
Reported: 2013-11-06 12:09 EST by Jonathon Jongsma
Modified: 2014-11-10 14:42 EST (History)
12 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2014-07-18 09:40:44 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
sherold: Triaged+

Attachments (Terms of Use)

  None (edit)
Description Jonathon Jongsma 2013-11-06 12:09:51 EST
virt-viewer currently has a --full-screen option that has an optional 'auto-conf' argument.  The main difference between the basic fullscreen mode and the auto-conf fullscreen mode is that basic fullscreen mode creates a window for each display that is currently configured on the guest and then makes these windows fullscreen.  If there are fewer guest displays than client monitors, the client monitors are left empty.  If there are *more* guest displays than client monitors, then all of the extra displays become windows hidden behind eachother on the last client monitor.

In contrast, when possible (i.e. with spice + vdagent) the auto-conf fullscreen mode tries to enable exactly the same number of guest displays as client monitors. This results in a much better user experience.  If auto-conf is unsupported, it behaves the same as basic fullscreen mode.

I propose to remove the distinction between these two modes and simply have a single mode that behaves as auto-conf currently does.
Comment 1 Marc-Andre Lureau 2013-11-06 14:30:17 EST
I think that's the way to go, that's way the patch in virt-viewer is already on it's way upstream. Hopefully we don't have to carry a RHEV only patch.
Comment 2 Michal Skrivanek 2013-11-08 05:27:53 EST
no objection from rhev side, we do need to clean up the mess in arguments being passed to spice in this specific area (ctrl-alt-del as well:)
Comment 3 Marc-Andre Lureau 2014-03-11 12:41:59 EDT
When is this RFE target? the earlier the better imho
Comment 7 Michal Skrivanek 2014-04-08 10:15:55 EDT
ok, let's do that...so what do we pass, what parameters and values exactly
- for .vv file
- for Firefox XPI / IE ActiveX plugin
Which version will support it? What about older clients behavior?
Comment 8 Jonathon Jongsma 2014-04-08 10:48:35 EDT
For new clients, fullscreen will imply auto-conf. So any explicit auto-conf arguments will simply be ignored. So we should try to make both new and old clients always do auto-conf when fullscreen is selected.  

In the case of the spi/activex plugins, you should probably set both FULL_SCREEN and AUTO_DISPLAY_RES to true.  The new client will simply ignore the AUTO_DISPLAY_RES flag, but will do auto-conf regardless.

For the vv-file, it's a bit more difficult to make old and new clients behave exactly the same because the vv-file format does not currently have a field for specifying auto-conf. There is only a single 'fullscreen' field that can be set.  If 'fullscreen' is set to 1, the new client would do auto-conf, but the old client would not. This issue is not specific to this change, however, since it also affects current RHEVM. See Bug 1083203 for discussion on addressing this issue.
Comment 9 Michal Skrivanek 2014-04-10 05:29:05 EDT
*** Bug 1002690 has been marked as a duplicate of this bug. ***
Comment 10 Michal Skrivanek 2014-04-10 05:34:25 EDT
ok, so it seems currently we need to:
1) on SPICE side to ignore the auto_res property. We are passing fullscreen to .vv and plugins accordingly.
2) in Basic User Portal correctly set default to "fullscreen" (doesn't work in 3.3)
Comment 11 Frantisek Kobzik 2014-05-12 09:56:56 EDT
Closing because since 3.4 fullscreen flag default is set correctly to true in basic user portal.
Comment 12 Frantisek Kobzik 2014-05-12 10:13:58 EDT
Hi Jonathon,

I'd like to handle this bug (I closed it already but I'm not sure if it's a good think). I'd like to ask you if Michal's 1st point in comment #10 is taken care of.

Comment 13 Jonathon Jongsma 2014-05-12 17:03:13 EDT
I'm not entirely sure what Michal meant by "on SPICE side" in point #1.  If it means the spice client (e.g. remote-viewer), then it is being handled.
Comment 14 Michal Skrivanek 2014-06-25 03:43:16 EDT
(In reply to Jonathon Jongsma from comment #13)
can you please link the corresponding bug # for the spice-client just so we have a complete set of prerequisites to test this?
Comment 15 Michal Skrivanek 2014-07-18 06:17:54 EDT
(In reply to Frantisek Kobzik from comment #11)
doesn't seem to be set correctly in 3.4 GA
Comment 16 Frantisek Kobzik 2014-07-18 09:40:44 EDT
After further investigation it appears the fullscreen flag is set correctly:
 - true in _basic_ user portal
 - false otherwise.

Note You need to log in before you can comment on or make changes to this bug.