Bug 1003779
| Summary: | Add/remove VNICs in new VM dialog | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Lior Vernia <lvernia> |
| Component: | ovirt-engine-webadmin-portal | Assignee: | Lior Vernia <lvernia> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Meni Yakove <myakove> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 3.3.0 | CC: | acathrow, bazulay, ecohen, gcheresh, iheim, lpeer, masayag, Rhev-m-bugs, yeylon |
| Target Milestone: | --- | ||
| Target Release: | 3.3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | network | ||
| Fixed In Version: | is18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 999283 | ||
| Bug Blocks: | 1009298 | ||
|
Description
Lior Vernia
2013-09-03 08:01:50 UTC
that's quite a behavior change. agree we should preserve "template with no nic == vm with no nic's" by default. allowing to add vnic's is welcome if possible (I assume we'll be using defaults (virtio, etc.) here. (In reply to Itamar Heim from comment #1) > that's quite a behavior change. agree we should preserve "template with no > nic == vm with no nic's" by default. allowing to add vnic's is welcome if > possible (I assume we'll be using defaults (virtio, etc.) here. There is no behaviour change. The engine creates the vm according to the template. The UI adds by default an interface in the "New VM" dialog, although it is not part of the template's configuration. This bug suggests not to add that default vnic in the dialog, so the actual configuration of the template will be reflected to the user. It will allow the user to add new interface on the same "New VM" dialog, that will be interpreted as 'AddVmInterface" commands. moti - i think we are saying the same thing. adding a vnic for a template without a vnic is a behavior change/bug. Just to make sure we're all on the same page... 1. "At the present time" (dependent upon a patch pending review), when a VM is created from template, its number of VNICs and default profile assignment will be generated according to the template, UNLESS the template has no VNICs to begin with, in which case one VNIC will be created by default (as long as there are valid profiles to attach to it). 2. A solution to this bug would enable the user to add or remove VNICs within the add/edit VM dialog, in which case the "UNLESS" clause above will no longer be required, and the default suggestion for profile configuration should be identical to the template, ALWAYS, even if it has no VNICs. This would only encompass frontend changes, which may or may not be referred to as "behavior change" as a function of perspective :) Does anybody have a different picture in mind? Today when you create VM from blank template, the NIC with empty profile is created, when more reasonable is to create VM without any VNIC. If you create such a VM in 3.1 DC/Cluster the creation will fail as VM with empty profile/network was not supported there. Resolution of this bug should take it in mind rhevm-3.3.0-0.25.beta1.el6ev.noarch Closing - RHEV 3.3 Released Closing - RHEV 3.3 Released Closing - RHEV 3.3 Released |