Bug 1004094
| Summary: | Review Request: cups-x2go - CUPS backend for printing from X2Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | cups-x2go-3.0.0.4-2.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-23 00:37:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 998551 | ||
|
Description
Orion Poplawski
2013-09-03 22:57:26 UTC
Improvement:
1. Avoid attr() nowadays. Please correc its permission when installing it:
install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/
2. Drop %doc as it doesn't exist.
3. %{_sysconfdir}/cups/cups-x2go.conf
should be added %config(noreplace)
4. New Fedora Review tool is very nice, it told me that you shouldn't own a dir already taken by other packages:
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/x2go(x2goserver),
/usr/share/x2go/versions(x2goserver)
So you should correct %{_datadir}/x2go/.
5. cups-x2go.noarch: W: non-standard-group Server
So, fix it or drop the group tag.
6. cups-x2go.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
(In reply to Christopher Meng from comment #1) > Improvement: > > 1. Avoid attr() nowadays. Please correc its permission when installing it: > > install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/ > > 2. Drop %doc as it doesn't exist. > > 3. %{_sysconfdir}/cups/cups-x2go.conf > > should be added %config(noreplace) All fixed. > 4. New Fedora Review tool is very nice, it told me that you shouldn't own a > dir already taken by other packages: > > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/share/x2go(x2goserver), > /usr/share/x2go/versions(x2goserver) > > So you should correct %{_datadir}/x2go/. The problem is the cups-x2go can be installed independently of x2goserver, so they both need to own it. > 5. cups-x2go.noarch: W: non-standard-group Server > > So, fix it or drop the group tag. Fixed - kept for EL6 > 6. cups-x2go.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: > line 1) Fixed * Wed Sep 4 2012 Orion Poplawski <orion.com> 3.0.0.4-2 - Use install to set permissions on cups-x2go - Drop %%doc for now - Mark config file as %%config(noreplace) - Fix Group - Drop tabs http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go.spec http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go-3.0.0.4-2.fc19.src.rpm OK. APPROVED. New Package SCM Request ======================= Package Name: cups-x2go Short Description: CUPS backend for printing from X2Go Owners: orion Branches: f20 f19 f18 el6 InitialCC: Thanks for the review! Git done (by process-git-requests). cups-x2go-3.0.0.4-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/cups-x2go-3.0.0.4-2.fc20 cups-x2go-3.0.0.4-2.fc20 has been pushed to the Fedora 20 testing repository. cups-x2go-3.0.0.4-2.fc20 has been pushed to the Fedora 20 stable repository. |