Bug 1004094 - Review Request: cups-x2go - CUPS backend for printing from X2Go
Summary: Review Request: cups-x2go - CUPS backend for printing from X2Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 998551
TreeView+ depends on / blocked
 
Reported: 2013-09-03 22:57 UTC by Orion Poplawski
Modified: 2013-10-19 21:12 UTC (History)
2 users (show)

Fixed In Version: cups-x2go-3.0.0.4-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-23 00:37:21 UTC
Type: ---
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Orion Poplawski 2013-09-03 22:57:26 UTC
Spec URL: http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go-3.0.0.4-1.fc19.src.rpm
Description: 
CUPS backend for printing from X2Go.

Fedora Account System Username: orion

Comment 1 Christopher Meng 2013-09-04 04:43:12 UTC
Improvement:

1. Avoid attr() nowadays. Please correc its permission when installing it:

install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/

2. Drop %doc as it doesn't exist.

3. %{_sysconfdir}/cups/cups-x2go.conf

should be added %config(noreplace)

4. New Fedora Review tool is very nice, it told me that you shouldn't own a dir already taken by other packages:

[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/x2go(x2goserver),
     /usr/share/x2go/versions(x2goserver)

So you should correct %{_datadir}/x2go/.

5. cups-x2go.noarch: W: non-standard-group Server

So, fix it or drop the group tag.

6. cups-x2go.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)

Comment 2 Orion Poplawski 2013-09-04 16:02:48 UTC
(In reply to Christopher Meng from comment #1)
> Improvement:
> 
> 1. Avoid attr() nowadays. Please correc its permission when installing it:
> 
> install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/
> 
> 2. Drop %doc as it doesn't exist.
> 
> 3. %{_sysconfdir}/cups/cups-x2go.conf
> 
> should be added %config(noreplace)

All fixed.

> 4. New Fedora Review tool is very nice, it told me that you shouldn't own a
> dir already taken by other packages:
> 
> [!]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by: /usr/share/x2go(x2goserver),
>      /usr/share/x2go/versions(x2goserver)
> 
> So you should correct %{_datadir}/x2go/.

The problem is the cups-x2go can be installed independently of x2goserver, so they both need to own it.
 
> 5. cups-x2go.noarch: W: non-standard-group Server
> 
> So, fix it or drop the group tag.

Fixed - kept for EL6

> 6. cups-x2go.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab:
> line 1)

Fixed

* Wed Sep 4 2012 Orion Poplawski <orion@cora.nwra.com> 3.0.0.4-2
- Use install to set permissions on cups-x2go
- Drop %%doc for now
- Mark config file as %%config(noreplace)
- Fix Group
- Drop tabs

http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go.spec
http://www.cora.nwra.com/~orion/fedora/nx/cups-x2go-3.0.0.4-2.fc19.src.rpm

Comment 3 Christopher Meng 2013-09-05 00:16:58 UTC
OK.

APPROVED.

Comment 4 Orion Poplawski 2013-09-05 01:08:55 UTC
New Package SCM Request
=======================
Package Name: cups-x2go
Short Description: CUPS backend for printing from X2Go
Owners: orion
Branches: f20 f19 f18 el6
InitialCC:

Comment 5 Orion Poplawski 2013-09-05 01:09:15 UTC
Thanks for the review!

Comment 6 Gwyn Ciesla 2013-09-05 12:16:18 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-09-05 15:19:09 UTC
cups-x2go-3.0.0.4-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/cups-x2go-3.0.0.4-2.fc20

Comment 8 Fedora Update System 2013-09-05 17:52:42 UTC
cups-x2go-3.0.0.4-2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 9 Fedora Update System 2013-09-23 00:37:21 UTC
cups-x2go-3.0.0.4-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.