Bug 1008242

DON'T LIFT fedora-review flag BY YOURSELF.

Let's start from SPEC itself first.

1. No need to use %{name} in %summary as it will be immutable if this software sdoesn't have some mass changes, so just use gti is good(3chars vs. 7chars), what do you think?

2. Its URL is http://r-wos.org/hacks/gti, not its github url.

3. Please visit its real homepage and change your %description. Too short.

4. If no %doc present, please remove the line with %doc

BUT, you MUST request a LICENSE from upstream or include it as %doc if it's already in the tarball.

5. %{_mandir}/man6/%{name}.6.gz

Please use

%{_mandir}/man6/%{name}.6* because RPM will help compress the ungzipped manpages if your makefile doesn't do that.

Run rpmlint (or rpmlint -i for more helpful output) on the src.rpm and all
built rpms. Feel free to ignore obvious false positives in the report, but fix
anything else. Preferably add a comment here about whether/when you think what
rpmlint reports is correct or incorrect.


> 1.

%{name} is completely wrong here: gti != git


> 4.

That's not a MUST but a SHOULD:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text


> 5.

It helps not just with uncompressed man pages, but also if the compression technique is changed. There's no immediate need to change it, it's just a hint for packagers since rpmbuild compressed man pages on-the-fly. In this case, the Makefile gzips the man page.


> %build
> make %{?_smp_mflags}

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages

ping here.

NEWS?

Hey,

sorry i was bussy... 

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003

1. You'd better drop Group:Amusements/Games. Nonsense.

2. Read comment 3 carefully.

Don't erase the changelog in the past.

If you can't fix this for another long time, I will close this again.

- changed the GROUP to Nonsense

- contacted  Richard Wossal to provide license in source, still waiting for response

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003

1. I meant drop.

2. Please read Michael's comment _carefully_:

> > %build
> > make %{?_smp_mflags}
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
> https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages

%build
make %{?_smp_mflags} CFLAGS="%{optflags}"

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.J9j6eF
+ umask 022
+ cd /builddir/build/BUILD
+ cd gti-1.2.0
+ make -j2 'CFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables'
gcc -o gti  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables  gti.c
strip -s gti

Debug sumbols have been stripped.

-nostrip.patch

https://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-nostrip.patch

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003

Forgot to mention, set LDFLAGS="%{?__global_ldflags}"

-LDFLAGS="%{?__global_ldflags}"

https://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-nostrip.patch

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003

PACKAGE APPROVED.

New Package SCM Request
=======================
Package Name: gti
Short Description: Just a silly gti launcher
Upstream URL: http://r-wos.org/hacks/gti
Owners: ib54003
Branches: f20

Git done (by process-git-requests).

Added f21.