Bug 1008772

Drop by comments:

1. Requires: hidapi = %{version}-%{release}

-->

Requires:       %{name}%{?_isa} = %{version}-%{release}

2. %package -n hidapi-devel

-->

%package devel

%files -n hidapi-devel

-->

%files devel

3. %dir %{_includedir}/hidapi
%{_includedir}/hidapi/hidapi.h

-->

%{_includedir}/hidapi

4. Tiny question, why not use this URL as Github has offered such function:

https://github.com/downloads/signal11/hidapi/hidapi-0.7.0.zip

Thanks a lot for the comments.  I incorporated those changes.

On #4 - the reason I am not using the released version (0.7.0) is that it is quite old and has many bugs.  The upstream maintainer does not make releases regularly, so I am using a git snapshot.

Thanks,
Scott

Taken.

*** Bug 877694 has been marked as a duplicate of this bug. ***

Would you like to add BR of fox-utils so you can test the GUI(https://github.com/signal11/hidapi/blob/master/README.txt#L148)?

(In reply to Christopher Meng from comment #5)
> Would you like to add BR of fox-utils so you can test the
> GUI(https://github.com/signal11/hidapi/blob/master/README.txt#L148)?

I disabled building the test GUI (--disable-testgui) as I wasn't sure it was useful (I've not used it) and I was concerned about adding additional library dependencies - it seems like a low-level USB/Bluetooth library shouldn't depend on a GUI library.  If you feel like it should be included, perhaps it should be a separate package, like hidapi-testgui or something.  But I'm just as inclined to leave it out.

(In reply to Scott Talbert from comment #6)
> I disabled building the test GUI (--disable-testgui) as I wasn't sure it was
> useful (I've not used it) and I was concerned about adding additional
> library dependencies - it seems like a low-level USB/Bluetooth library
> shouldn't depend on a GUI library.  If you feel like it should be included,
> perhaps it should be a separate package, like hidapi-testgui or something. 
> But I'm just as inclined to leave it out.

Good reason, agree.

Package is fine, however I can find a udev rules in git, can you tell me if we need it, too?

(In reply to Christopher Meng from comment #7)
> Package is fine, however I can find a udev rules in git, can you tell me if
> we need it, too?

No, we don't need it.  That is just a sample udev rules file that could be used with some device.  Packages that use hidapi may wish to supply a udev rules file, but hidapi shouldn't provide a packaged one.

Then everything is fine at present.

PACKAGE APPROVED.

New Notes:


%install
rm -rf $RPM_BUILD_ROOT

Please remove.

---------------

%post -n hidapi -p /sbin/ldconfig
%postun -n hidapi -p /sbin/ldconfig


--->

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

(In reply to Christopher Meng from comment #10)
> New Notes:
> 
> 
> %install
> rm -rf $RPM_BUILD_ROOT
> 
> Please remove.
> 
> ---------------
> 
> %post -n hidapi -p /sbin/ldconfig
> %postun -n hidapi -p /sbin/ldconfig
> 
> 
> --->
> 
> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

Fixes incorporated.
SPEC: http://www.techie.net/~talbert/hidapi/hidapi.spec
SRPM: http://www.techie.net/~talbert/hidapi/hidapi-0.7.0-2.a88c724.fc19.src.rpm

New Package SCM Request
=======================
Package Name: hidapi
Short Description: Library for communicating with USB and Bluetooth HID devices
Owners: swt2c
Branches: f19 f20
InitialCC:

Git done (by process-git-requests).

hidapi-0.7.0-2.a88c724.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/hidapi-0.7.0-2.a88c724.fc20

hidapi-0.7.0-2.a88c724.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/hidapi-0.7.0-2.a88c724.fc19

hidapi-0.7.0-2.a88c724.fc20 has been pushed to the Fedora 20 testing repository.

hidapi-0.7.0-2.a88c724.fc20 has been pushed to the Fedora 20 stable repository.

hidapi-0.7.0-2.a88c724.fc19 has been pushed to the Fedora 19 stable repository.