Bug 1008772 - Review Request: hidapi - Library for communicating with USB and Bluetooth HID devices
Summary: Review Request: hidapi - Library for communicating with USB and Bluetooth HID...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 877694 (view as bug list)
Depends On:
Blocks: 1022317
TreeView+ depends on / blocked
 
Reported: 2013-09-17 04:20 UTC by Scott Talbert
Modified: 2013-11-11 02:29 UTC (History)
4 users (show)

Fixed In Version: hidapi-0.7.0-2.a88c724.fc19
Clone Of:
Environment:
Last Closed: 2013-11-10 06:58:37 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Scott Talbert 2013-09-17 04:20:54 UTC
Spec URL: http://www.techie.net/~talbert/hidapi/hidapi.spec
SRPM URL: http://www.techie.net/~talbert/hidapi/hidapi-0.7.0-1.a88c724.fc19.src.rpm

Description: HIDAPI is a multi-platform library which allows an application to interface with USB and Bluetooth HID-class devices on Windows, Linux, FreeBSD and Mac OS X.  On Linux, either the hidraw or the libusb back-end can be used. There are trade-offs and the functionality supported is slightly different.

Fedora Account System Username: swt2c

Koji Build Task: http://koji.fedoraproject.org/koji/taskinfo?taskID=5943782

Thanks,
Scott

Comment 1 Christopher Meng 2013-10-23 03:58:14 UTC
Drop by comments:

1. Requires: hidapi = %{version}-%{release}

-->

Requires:       %{name}%{?_isa} = %{version}-%{release}

2. %package -n hidapi-devel

-->

%package devel

%files -n hidapi-devel

-->

%files devel

3. %dir %{_includedir}/hidapi
%{_includedir}/hidapi/hidapi.h

-->

%{_includedir}/hidapi

4. Tiny question, why not use this URL as Github has offered such function:

https://github.com/downloads/signal11/hidapi/hidapi-0.7.0.zip

Comment 2 Scott Talbert 2013-10-23 22:43:55 UTC
Thanks a lot for the comments.  I incorporated those changes.

On #4 - the reason I am not using the released version (0.7.0) is that it is quite old and has many bugs.  The upstream maintainer does not make releases regularly, so I am using a git snapshot.

Thanks,
Scott

Comment 3 Christopher Meng 2013-10-25 01:51:10 UTC
Taken.

Comment 4 Christopher Meng 2013-10-25 02:41:49 UTC
*** Bug 877694 has been marked as a duplicate of this bug. ***

Comment 5 Christopher Meng 2013-10-25 04:13:48 UTC
Would you like to add BR of fox-utils so you can test the GUI(https://github.com/signal11/hidapi/blob/master/README.txt#L148)?

Comment 6 Scott Talbert 2013-10-28 02:27:04 UTC
(In reply to Christopher Meng from comment #5)
> Would you like to add BR of fox-utils so you can test the
> GUI(https://github.com/signal11/hidapi/blob/master/README.txt#L148)?

I disabled building the test GUI (--disable-testgui) as I wasn't sure it was useful (I've not used it) and I was concerned about adding additional library dependencies - it seems like a low-level USB/Bluetooth library shouldn't depend on a GUI library.  If you feel like it should be included, perhaps it should be a separate package, like hidapi-testgui or something.  But I'm just as inclined to leave it out.

Comment 7 Christopher Meng 2013-10-29 05:18:28 UTC
(In reply to Scott Talbert from comment #6)
> I disabled building the test GUI (--disable-testgui) as I wasn't sure it was
> useful (I've not used it) and I was concerned about adding additional
> library dependencies - it seems like a low-level USB/Bluetooth library
> shouldn't depend on a GUI library.  If you feel like it should be included,
> perhaps it should be a separate package, like hidapi-testgui or something. 
> But I'm just as inclined to leave it out.

Good reason, agree.

Package is fine, however I can find a udev rules in git, can you tell me if we need it, too?

Comment 8 Scott Talbert 2013-10-29 15:34:01 UTC
(In reply to Christopher Meng from comment #7)
> Package is fine, however I can find a udev rules in git, can you tell me if
> we need it, too?

No, we don't need it.  That is just a sample udev rules file that could be used with some device.  Packages that use hidapi may wish to supply a udev rules file, but hidapi shouldn't provide a packaged one.

Comment 9 Christopher Meng 2013-10-29 15:36:23 UTC
Then everything is fine at present.

PACKAGE APPROVED.

Comment 10 Christopher Meng 2013-10-29 15:38:02 UTC
New Notes:


%install
rm -rf $RPM_BUILD_ROOT

Please remove.

---------------

%post -n hidapi -p /sbin/ldconfig
%postun -n hidapi -p /sbin/ldconfig


--->

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

Comment 11 Scott Talbert 2013-10-29 23:59:03 UTC
(In reply to Christopher Meng from comment #10)
> New Notes:
> 
> 
> %install
> rm -rf $RPM_BUILD_ROOT
> 
> Please remove.
> 
> ---------------
> 
> %post -n hidapi -p /sbin/ldconfig
> %postun -n hidapi -p /sbin/ldconfig
> 
> 
> --->
> 
> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

Fixes incorporated.
SPEC: http://www.techie.net/~talbert/hidapi/hidapi.spec
SRPM: http://www.techie.net/~talbert/hidapi/hidapi-0.7.0-2.a88c724.fc19.src.rpm

Comment 12 Scott Talbert 2013-10-30 23:09:02 UTC
New Package SCM Request
=======================
Package Name: hidapi
Short Description: Library for communicating with USB and Bluetooth HID devices
Owners: swt2c
Branches: f19 f20
InitialCC:

Comment 13 Gwyn Ciesla 2013-10-31 12:16:50 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2013-11-01 02:29:50 UTC
hidapi-0.7.0-2.a88c724.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/hidapi-0.7.0-2.a88c724.fc20

Comment 15 Fedora Update System 2013-11-01 02:36:12 UTC
hidapi-0.7.0-2.a88c724.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/hidapi-0.7.0-2.a88c724.fc19

Comment 16 Fedora Update System 2013-11-01 20:25:24 UTC
hidapi-0.7.0-2.a88c724.fc20 has been pushed to the Fedora 20 testing repository.

Comment 17 Fedora Update System 2013-11-10 06:58:37 UTC
hidapi-0.7.0-2.a88c724.fc20 has been pushed to the Fedora 20 stable repository.

Comment 18 Fedora Update System 2013-11-11 02:29:09 UTC
hidapi-0.7.0-2.a88c724.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.