Bug 1009079

Summary: Guided rule editor does not escape bad characters
Product: [Retired] JBoss BRMS Platform 6 Reporter: Zuzana Krejčová <zkrejcov>
Component: Business CentralAssignee: Toni Rikkola <trikkola>
Status: CLOSED CURRENTRELEASE QA Contact: Zuzana Krejčová <zkrejcov>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0CC: etirelli, lpetrovi, rzhang
Target Milestone: ER6   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:19:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
corrupted rule
none
corrupted rule - source none

Description Zuzana Krejčová 2013-09-17 15:45:06 UTC
Created attachment 798871 [details]
corrupted rule

Description of problem:
Bad characters are not escaped in the guided rule editor: " and \ can seriously corrupt the rule.

Comment 1 Zuzana Krejčová 2013-09-17 15:45:34 UTC
Created attachment 798872 [details]
corrupted rule - source

Comment 5 Zuzana Krejčová 2013-12-09 10:09:08 UTC
Not fixed.

First, not allowing users to compare text fields (String attributes) using these characters (", \) is not a good solution. User now cannot type these chars into the input field. Please fix this.
Second, it is possible to do a copy&paste and if you add these character this way, they are still not escaped. Please, fix that as well.

Comment 6 Toni Rikkola 2013-12-12 12:37:50 UTC
User can now type anything and we escape the characters for the DRL source.


Link to the original fix. Just a reminder.
https://github.com/droolsjbpm/kie-wb-common/commit/77cde239bdb8a762f225708d206273bae5d90b67

New fix:
master https://github.com/droolsjbpm/kie-wb-common/commit/51ba48ba2
6.0.x https://github.com/droolsjbpm/kie-wb-common/commit/38fe77f00