Bug 1009079 - Guided rule editor does not escape bad characters
Summary: Guided rule editor does not escape bad characters
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ER6
: 6.0.0
Assignee: Toni Rikkola
QA Contact: Zuzana Krejčová
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-17 15:45 UTC by Zuzana Krejčová
Modified: 2016-08-01 01:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 20:19:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
corrupted rule (13.52 KB, image/png)
2013-09-17 15:45 UTC, Zuzana Krejčová
no flags Details
corrupted rule - source (8.96 KB, image/png)
2013-09-17 15:45 UTC, Zuzana Krejčová
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1198020 0 high CLOSED Guided editor does not escape bad characters - GDT, GRT Data table 2021-02-22 00:41:40 UTC

Internal Links: 1198020

Description Zuzana Krejčová 2013-09-17 15:45:06 UTC
Created attachment 798871 [details]
corrupted rule

Description of problem:
Bad characters are not escaped in the guided rule editor: " and \ can seriously corrupt the rule.

Comment 1 Zuzana Krejčová 2013-09-17 15:45:34 UTC
Created attachment 798872 [details]
corrupted rule - source

Comment 5 Zuzana Krejčová 2013-12-09 10:09:08 UTC
Not fixed.

First, not allowing users to compare text fields (String attributes) using these characters (", \) is not a good solution. User now cannot type these chars into the input field. Please fix this.
Second, it is possible to do a copy&paste and if you add these character this way, they are still not escaped. Please, fix that as well.

Comment 6 Toni Rikkola 2013-12-12 12:37:50 UTC
User can now type anything and we escape the characters for the DRL source.


Link to the original fix. Just a reminder.
https://github.com/droolsjbpm/kie-wb-common/commit/77cde239bdb8a762f225708d206273bae5d90b67

New fix:
master https://github.com/droolsjbpm/kie-wb-common/commit/51ba48ba2
6.0.x https://github.com/droolsjbpm/kie-wb-common/commit/38fe77f00


Note You need to log in before you can comment on or make changes to this bug.