Bug 1009583

Summary:	reserve workflow should not default to filtering by STABLE tag
Product:	[Retired] Beaker	Reporter:	mreynolds
Component:	general	Assignee:	beaker-dev-list
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.14	CC:	aigao, asaha, bpeck, dcallagh, jingwang, llim, qwan, rmancy, xjia
Target Milestone:	0.15.1
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-10-23 06:59:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description mreynolds 2013-09-18 16:16:50 UTC

Description of problem:

Select RedHatEnterpriseLinux7, but the "distro" and "tag" fields are not set, and no systems are listed in the lab field.

Version-Release number of selected component (if applicable):


How reproducible:

Everytime

Steps to Reproduce:
 See above.

Actual results:

Rhel7 builds are listed, and system architectures are listed.


Expected results:

To be able to reserve a rhel7 machine

Additional info:

Comment 2 Bill Peck 2013-09-18 16:43:25 UTC

This is because the reserve workflow defaults to tag STABLE and no RHEL7 distros have been tagged stable.

You can change the tag to "None Selected" and you will then get a list.

Comment 3 mreynolds 2013-09-18 17:05:19 UTC

(In reply to Bill Peck from comment #2)
> This is because the reserve workflow defaults to tag STABLE and no RHEL7
> distros have been tagged stable.
> 
> You can change the tag to "None Selected" and you will then get a list.

Yup, you're correct.  I don't recall having to do that the last time I reserved a rhel7 machine, so that's what threw me off.

Thanks,
Mark

Comment 4 Bill Peck 2013-09-18 19:45:03 UTC

I'm guessing we don't have any distros that RTT considers STABLE.

Comment 5 Dan Callaghan 2013-09-18 23:11:49 UTC

Bill, you might be thinking of RTT_ACCEPTED which is the tag added by RTT.

STABLE is supposed to be set by addDistro.d/updateDistro when the distro has been installed successfully. But that only happens if add_distro=1 is set in /etc/sysconfig/beaker_lab_import and if --run-jobs is passed to beaker-import. It looks like our crusty old Perl script to invoke beaker-import does not pass --run-jobs. I'm not sure if/when that regressed, but it must have been a long time ago, judging by the fact that no distros have been tagged STABLE since we added tag auditing.

Defaulting to STABLE tag in the reserve workflow is probably not wise since it assumes the Beaker administrator has got that working properly (and that they actually want to run those jobs). We might be better off defaulting to no tag filtering in reserve workflow.

Comment 6 Nick Coghlan 2013-09-30 02:40:41 UTC

For 0.15.1, we'll switch the reserve workflow to not care about the distro tags by default.

For 0.16 and later, bug 958590 should mean distros start getting tagged more reliably, but that won't directly impact the resolution of this issue.

Comment 7 Raymond Mancy 2013-10-14 10:42:35 UTC

http://gerrit.beaker-project.org/#/c/2358/

Comment 10 Raymond Mancy 2013-10-23 06:59:43 UTC

beaker 0.15.1 has been released.