Bug 1011041
| Summary: | Review Request: python3-py3dns - Python3 DNS library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i, notting |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-09 07:57:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1010829 | ||
|
Description
Ralph Bean
2013-09-23 14:13:32 UTC
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5971634 1. It would be better to use "https://launchpad.net/py3dns/" as URL tag. 2. Missing BuildRequires: python3-setuptools 3. %description needs work, after looking into lp homepage, you should change: This Python 3 module provides an DNS API for looking up DNS entries from within Python 3 modules and applications. This module is a simple, lightweight implementation. 4. fedora-review passed. PACKAGE APPROVED. CHANGE 1-3 MENTIONED ABOVE BEFORE IMPORT. Thanks Christopher. I will fix #1 and #3. #2 I think is not actually correct -- py3dns is one of the few python packages that doesn't actually require setuptools. Can you also set the fedora-review flag to "+"? (In reply to Ralph Bean from comment #3) > Thanks Christopher. > > I will fix #1 and #3. > > #2 I think is not actually correct -- py3dns is one of the few python > packages that doesn't actually require setuptools. > > Can you also set the fedora-review flag to "+"? Why it doesn't need it...? Ah, look in the setup.py file of the project. Most python packages use "from setuptools import setup" to declare their package. setuptools is third party and so must be included as a separate package. py3dns uses "from distutils.core import setup". distutils is in the python standard library and so requires no external package. New Package SCM Request ======================= Package Name: python3-py3dns Short Description: Python3 DNS library Owners: ralph Branches: f20 f19 f18 el6 InitialCC: Git done (by process-git-requests). Submitted to testing: https://admin.fedoraproject.org/updates/python3-py3dns |