Red Hat Bugzilla – Bug 1011041
Review Request: python3-py3dns - Python3 DNS library
Last modified: 2013-11-09 02:57:19 EST
Spec URL: http://ralph.fedorapeople.org//python3-py3dns.spec
SRPM URL: http://ralph.fedorapeople.org//python3-py3dns-3.0.4-1.fc19.src.rpm
Python3 DNS library
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5971634
1. It would be better to use "https://launchpad.net/py3dns/" as URL tag.
2. Missing BuildRequires: python3-setuptools
3. %description needs work, after looking into lp homepage, you should change:
This Python 3 module provides an DNS API for looking up DNS entries from
within Python 3 modules and applications. This module is a simple,
4. fedora-review passed.
CHANGE 1-3 MENTIONED ABOVE BEFORE IMPORT.
I will fix #1 and #3.
#2 I think is not actually correct -- py3dns is one of the few python packages that doesn't actually require setuptools.
Can you also set the fedora-review flag to "+"?
(In reply to Ralph Bean from comment #3)
> Thanks Christopher.
> I will fix #1 and #3.
> #2 I think is not actually correct -- py3dns is one of the few python
> packages that doesn't actually require setuptools.
> Can you also set the fedora-review flag to "+"?
Why it doesn't need it...?
Ah, look in the setup.py file of the project. Most python packages use "from setuptools import setup" to declare their package. setuptools is third party and so must be included as a separate package.
py3dns uses "from distutils.core import setup". distutils is in the python standard library and so requires no external package.
New Package SCM Request
Package Name: python3-py3dns
Short Description: Python3 DNS library
Branches: f20 f19 f18 el6
Git done (by process-git-requests).
Submitted to testing: https://admin.fedoraproject.org/updates/python3-py3dns
Hmm...not sure why I didn't understand in comment 4, I will keep clearheaded from now on...