Bug 1011111

Summary: Importing a JSON definition never failes even if the definition is invalid
Product: [Retired] JBoss BPMS Platform 6 Reporter: Sona Mala <smala>
Component: jBPM DesignerAssignee: Tihomir Surdilovic <tsurdilo>
Status: CLOSED CURRENTRELEASE QA Contact: Sona Mala <smala>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.0CC: kverlaen
Target Milestone: ER5   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:10:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sona Mala 2013-09-23 16:01:51 UTC
Description of problem:
Importing a JSON definition never fails even if this definition is invalid. In that case, Designer imports nothing (empty process).

Version-Release number of selected component (if applicable):
6.0.0. ER3

How reproducible:


Steps to Reproduce:
1. Create new process (Start -> Task -> End)
2. View its JSON definition and copy it (Ctrl+A, Ctrl+C) 
3. Open import dialog for JSON
4. Insert JSON definition and delete any character ('}', ']', etc.)

Actual results:
Alert "Importing..." is shown together with confirmation dialog "Replace existing model?". If you answer 'YES' then the empty process is shown.


Expected results:
Same behaviour as for BPMN2:
  - Alert "Failed to import JSON"
  - Alert with more specific message ("missing character", etc.)
  - no confirmation dialog
  - previous process is shown (without changes)


Additional info:

Comment 1 Tihomir Surdilovic 2013-09-30 15:42:54 UTC
fixed in designer master and 6.0.x branches

Comment 2 Sona Mala 2013-12-18 09:31:14 UTC
Verified for ER5