Bug 1011452

Summary: rlIsRHEL: Space between arguments handled badly
Product: [Fedora] Fedora Reporter: Petr Muller <pmuller>
Component: beakerlibAssignee: Petr Muller <pmuller>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ohudlick, pmuller, psplicha
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: Release
Fixed In Version: beakerlib-1.9-3.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1108730 (view as bug list) Environment:
Last Closed: 2014-07-30 06:57:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1108730, 1116308, 1116317    
Attachments:
Description Flags
Fix none

Description Petr Muller 2013-09-24 10:17:39 UTC 
Created attachment 802144 [details]
Fix

Description of problem:

>> search your tests[1] for incorrect usage of rlIsRHEL/rlIsFedora. If
>> you use rlIsRHEL/rlIsFedora with prefix consisting of ’<’, ’<=’, ’=’,
>> ’>=’, ’>’ there needs to be no space between this prefix and version
>> number or this command use silently returns true.
>>
>> [1] $ grep -P -r "(rlIsRHEL|rlIsFedora)(\d|\s)+['\"\\][<=>]+['\"]?\s"
>> /mnt/tests
>>
>> Have a nice day,
>>
>> -- Lukas -krtek.net- Novy BaseOS Security QE
>>
> That's IMO a bug in BL. Attached is a patch (+tests).
> 

I agree that the bug is an incorrect sanity check (which your patch
fixes), the "no space" behavior is however a feature as the following
is a valid scenario:

    rlIsRHEL '<=5' 6.2 6.4 '>=7'

The manpage could probably use some examples as well.

as for test_rlIsRHEL, we should probably test two-digit numbers as well,
like 5.10.
Comment 1 Petr Muller 2014-06-12 13:35:18 UTC 
https://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=55af0e9d5b99f379b466fc727ee7725e04267b7e
Comment 2 Fedora Update System 2014-06-17 13:41:25 UTC 
beakerlib-1.9-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-1.fc20
Comment 3 Fedora Update System 2014-06-17 23:28:56 UTC 
Package beakerlib-1.9-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beakerlib-1.9-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7442/beakerlib-1.9-1.fc20
then log in and leave karma (feedback).
Comment 4 Fedora Update System 2014-07-02 08:01:06 UTC 
beakerlib-1.9-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-2.fc20
Comment 5 Dalibor Pospíšil 2014-07-04 08:51:00 UTC 
Please consider the package fixing this bug available in Fedora stable repos once bz1116308 is closed and RHEL stable repos once bz1116317 is closed.

Fixed in:
beakerlib-1.9-2.fc19
beakerlib-1.9-2.fc20
beakerlib-1.9-2.fc21
beakerlib-1.9-3.el5
beakerlib-1.9-2.el6
beakerlib-1.9-2.el7
Comment 6 Fedora Update System 2014-07-17 13:15:34 UTC 
beakerlib-1.9-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-3.fc20
Comment 7 Fedora Update System 2014-07-30 06:57:05 UTC 
beakerlib-1.9-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.