Created attachment 802144 [details] Fix Description of problem: >> search your tests[1] for incorrect usage of rlIsRHEL/rlIsFedora. If >> you use rlIsRHEL/rlIsFedora with prefix consisting of ’<’, ’<=’, ’=’, >> ’>=’, ’>’ there needs to be no space between this prefix and version >> number or this command use silently returns true. >> >> [1] $ grep -P -r "(rlIsRHEL|rlIsFedora)(\d|\s)+['\"\\][<=>]+['\"]?\s" >> /mnt/tests >> >> Have a nice day, >> >> -- Lukas -krtek.net- Novy BaseOS Security QE >> > That's IMO a bug in BL. Attached is a patch (+tests). > I agree that the bug is an incorrect sanity check (which your patch fixes), the "no space" behavior is however a feature as the following is a valid scenario: rlIsRHEL '<=5' 6.2 6.4 '>=7' The manpage could probably use some examples as well. as for test_rlIsRHEL, we should probably test two-digit numbers as well, like 5.10.
https://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=55af0e9d5b99f379b466fc727ee7725e04267b7e
beakerlib-1.9-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/beakerlib-1.9-1.fc20
Package beakerlib-1.9-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing beakerlib-1.9-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-7442/beakerlib-1.9-1.fc20 then log in and leave karma (feedback).
beakerlib-1.9-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/beakerlib-1.9-2.fc20
Please consider the package fixing this bug available in Fedora stable repos once bz1116308 is closed and RHEL stable repos once bz1116317 is closed. Fixed in: beakerlib-1.9-2.fc19 beakerlib-1.9-2.fc20 beakerlib-1.9-2.fc21 beakerlib-1.9-3.el5 beakerlib-1.9-2.el6 beakerlib-1.9-2.el7
beakerlib-1.9-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/beakerlib-1.9-3.fc20
beakerlib-1.9-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.