Bug 1011853

Summary:	/etc/sysconfig/nfs sets variables that are not used by the nfs service
Product:	[Retired] oVirt	Reporter:	Yedidyah Bar David <didi>
Component:	ovirt-engine-installer	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.3	CC:	abaron, acathrow, didi, iheim, oschreib, sbonazzo, yeylon
Target Milestone:	---
Target Release:	3.3.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	storage
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-25 11:50:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yedidyah Bar David 2013-09-25 08:56:43 UTC

Description of problem:

conf/nfs.sysconfig.in, which is used to update /etc/sysconfig/nfs,
sets variables that are no longer used in recent fedora nfs-utils
init scripts.

In particular, configuring iptables/firewalld to open nfs access
to the host to serve the ISO domain, does not work, as e.g. mountd
runs with its default port number and not the open opened in iptables.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. run engine-setup, choose to configure an ISO domain
2. run 'ps -ef | grep mountd'

Actual results:

rpc.mountd runs with default options

Expected results:

rpc.mountd should run with '-p 892'

Additional info:

Comment 1 Itamar Heim 2013-09-25 16:05:51 UTC

are they needed by .el6 still?

Comment 2 Itamar Heim 2013-09-27 16:24:30 UTC

flagging storage for their input to this, even if implementation is covered by integration

Comment 3 Yedidyah Bar David 2013-09-29 05:50:25 UTC

(In reply to Itamar Heim from comment #1)
> are they needed by .el6 still?

They are not "needed". In el6, there are e.g. both MOUNTD_PORT and RPCMOUNTDOPTS. In (recent enough) fedora there is only RPCMOUNTDOPTS. So using RPCMOUNTDOPTS works on both.

Why did the people packaging nfs-utils on fedora "went back"? I guess because they wanted to run the various daemons from systemd directly, without going through wrapper scripts. Doing something like
        [ -n "$MOUNTD_PORT" ] \
        && RPCMOUNTDOPTS="$RPCMOUNTDOPTS -p $MOUNTD_PORT"
in /etc/init.d/nfs on el6 is easy, but if you want something similar in systemd, you can't staff it into the service file, which is currently:
EnvironmentFile=-/etc/sysconfig/nfs
ExecStart=/usr/sbin/rpc.mountd $RPCMOUNTDOPTS
you have to make a wrapper script.

That's just a guess, of course, and while I might not agree with the decision to do that, I can understand the reasoning behind it.

Comment 4 Ayal Baron 2013-09-29 12:41:32 UTC

Itamar, I'm not sure what the question here is?
Didi covered the technical side.  I've commented on the patch.

Comment 5 Sandro Bonazzola 2013-10-21 14:09:11 UTC

Included in 3.3.1 beta

Comment 6 Sandro Bonazzola 2013-11-25 11:50:51 UTC

oVirt 3.3.1 has been released