Bug 1012972

Summary:	Enter in 'Do you want to close the session?' dialog should be equal to hitting 'OK' button
Product:	Red Hat Enterprise Linux 6	Reporter:	David Jaša <djasa>
Component:	virt-viewer	Assignee:	Christophe Fergeau <cfergeau>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.6	CC:	cfergeau, codong, dblechte, desktop-qa-list, dyuan, lcui, marcandre.lureau, mzhan, rbalakri, tzheng, zsong
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-viewer-0.6.0-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1020669 (view as bug list)		Environment:
Last Closed:	2014-10-14 06:29:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1020669

Description David Jaša 2013-09-27 13:20:14 UTC

Description of problem:
Enter key in dialogs is usually equivalent of hitting OK button. This is not the case with virt-viewer where it toggles the widget with default focus - "Do not ask me again" checkbox. The default focus is correct IMO as it allows to toggle the checkbox with a single spacebar stroke but the Enter should work as usual, not to be redunant to spacebar.

Version-Release number of selected component (if applicable):
virt-viewer-0.5.6-8
spice-gtk-0.20-9

How reproducible:
always

Steps to Reproduce:
1. connect with virt-viewer to some VM
2. File --> Exit
3. hit Enter

Actual results:
"Do not ask me again" is selected

Expected results:
virt-viewer exits

Additional info:

Comment 1 RHEL Program Management 2013-10-14 01:54:01 UTC

This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

Comment 2 tingting zheng 2013-10-18 05:44:52 UTC

I can reproduce this bug with virt-viewer-0.5.6-8.el6.x86_64.

Comment 3 Marc-Andre Lureau 2013-10-18 11:04:40 UTC

Should be addressed by https://git.fedorahosted.org/cgit/virt-viewer.git/commit/?id=697b4929ac22a1014db0b81270d1d01b51a773bf

Comment 4 Christophe Fergeau 2013-10-18 12:13:21 UTC

(with the caveat that this will activate Cancel by default, not Ok which I think is consistent with the intent of the dialog)

Comment 5 David Jaša 2013-10-18 15:49:37 UTC

(In reply to Christophe Fergeau from comment #4)
> (with the caveat that this will activate Cancel by default, not Ok which I
> think is consistent with the intent of the dialog)

That's not the right outcome. The default keyboard focus on checkbox is correct IMO, just the "Enter" key meaning should be changed to be "OK".

Comment 6 Christophe Fergeau 2013-10-18 15:59:13 UTC

The warning really means 'you are about to do something that may not be what you want, is it really ok?'
With such warnings, I think the right default action is to not carry on with what the user tries to do.

Comment 8 Cui Lei 2014-06-05 05:44:14 UTC

I can reproduce this issue with virt-viewer-0.5.6-8.el6.x86_64

Verify the issue with:
virt-viewer-0.6.0-4.el6

1. connect with virt-viewer to some VM
2. File --> Exit
3. hit Enter

Click 'Enter' key would activate Cancel, not enable 'Do not ask me again' before.

So change the status from 'ON_QA' to 'VERIFIED'.

Comment 9 errata-xmlrpc 2014-10-14 06:29:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1379.html