Bug 1014356

Summary: graphite-web CarbonLink error: UnpicklingError: Attempting to unpickle unsafe module collections
Product: [Fedora] Fedora EPEL Reporter: James Juran <james.juran>
Component: graphite-webAssignee: Jonathan Steffan <jonathansteffan>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: el6CC: jonathansteffan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: graphite-web-0.9.12-5.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-05 02:49:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
possible fix none

Description James Juran 2013-10-01 19:30:47 UTC
Created attachment 806144 [details]
possible fix

graphite-web 0.9.12 fixes a security issue with unpickling. Unfortunately it also seems to block data being returned via CarbonLink from the carbon-cache daemons. This is reported upstream at https://github.com/graphite-project/graphite-web/issues/423 . The attached patch is one way to fix it, but I do not know if it is the correct way.

Comment 1 Jonathan Steffan 2013-10-01 22:04:50 UTC
I'm not comfortable patching this until upstream commits a proper fix into master. I don't want to introduce anything into this CVE fix without upstream committing the change.

Comment 2 Jonathan Steffan 2013-10-01 22:48:32 UTC
After more closely reading the suggested patch and a little discussion on freenode, I'm more comfortable adding deque to the allowed PICKLE_SAFE. I wonder if carbon.util would also be appropriately patched but I am going to keep this patch isolated to graphite.util as it resolves this exact CarbonLink issue.

I will be doing a build with this fix shortly.

Comment 3 Jonathan Steffan 2013-10-01 23:33:35 UTC
http://koji.fedoraproject.org/koji/buildinfo?buildID=468883 has these patches applied. I will be waiting to issue this to -testing until I can mark the currently pending updates as stable.

Comment 4 James Juran 2013-10-02 01:19:47 UTC
Thank you Jonathan. If you have any useful input on the correctness of this approach, could you please comment in https://github.com/graphite-project/graphite-web/issues/423 to help get this merged upstream? The issue seems to be waiting for input from someone with more knowledge of Graphite/Carbon internals than I have acquired so far.

Comment 5 Fedora Update System 2013-10-25 15:04:51 UTC
graphite-web-0.9.12-5.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.el6

Comment 6 Fedora Update System 2013-10-25 15:05:10 UTC
graphite-web-0.9.12-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.fc19

Comment 7 Fedora Update System 2013-10-25 15:05:28 UTC
graphite-web-0.9.12-5.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.el5

Comment 8 Fedora Update System 2013-10-25 15:05:46 UTC
graphite-web-0.9.12-5.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.fc20

Comment 9 Fedora Update System 2013-10-25 15:06:02 UTC
graphite-web-0.9.12-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.fc18

Comment 10 Fedora Update System 2013-10-25 17:39:04 UTC
Package graphite-web-0.9.12-5.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing graphite-web-0.9.12-5.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11952/graphite-web-0.9.12-5.el6
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2013-11-05 02:49:02 UTC
graphite-web-0.9.12-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2013-11-05 02:53:13 UTC
graphite-web-0.9.12-5.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2013-11-10 08:15:28 UTC
graphite-web-0.9.12-5.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2013-11-10 20:17:55 UTC
graphite-web-0.9.12-5.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2013-11-10 20:18:12 UTC
graphite-web-0.9.12-5.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.