Created attachment 806144 [details] possible fix graphite-web 0.9.12 fixes a security issue with unpickling. Unfortunately it also seems to block data being returned via CarbonLink from the carbon-cache daemons. This is reported upstream at https://github.com/graphite-project/graphite-web/issues/423 . The attached patch is one way to fix it, but I do not know if it is the correct way.
I'm not comfortable patching this until upstream commits a proper fix into master. I don't want to introduce anything into this CVE fix without upstream committing the change.
After more closely reading the suggested patch and a little discussion on freenode, I'm more comfortable adding deque to the allowed PICKLE_SAFE. I wonder if carbon.util would also be appropriately patched but I am going to keep this patch isolated to graphite.util as it resolves this exact CarbonLink issue. I will be doing a build with this fix shortly.
http://koji.fedoraproject.org/koji/buildinfo?buildID=468883 has these patches applied. I will be waiting to issue this to -testing until I can mark the currently pending updates as stable.
Thank you Jonathan. If you have any useful input on the correctness of this approach, could you please comment in https://github.com/graphite-project/graphite-web/issues/423 to help get this merged upstream? The issue seems to be waiting for input from someone with more knowledge of Graphite/Carbon internals than I have acquired so far.
graphite-web-0.9.12-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.el6
graphite-web-0.9.12-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.fc19
graphite-web-0.9.12-5.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.el5
graphite-web-0.9.12-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.fc20
graphite-web-0.9.12-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/graphite-web-0.9.12-5.fc18
Package graphite-web-0.9.12-5.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing graphite-web-0.9.12-5.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11952/graphite-web-0.9.12-5.el6 then log in and leave karma (feedback).
graphite-web-0.9.12-5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.