Bug 1015094

Summary: Unable to build inkscape from src.rpm
Product: Red Hat Enterprise Linux 7 Reporter: Martin Simon <msimon>
Component: inkscapeAssignee: Jan Horak <jhorak>
Status: CLOSED NOTABUG QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.0CC: stransky, tpelka
Target Milestone: beta   
Target Release: 7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-17 14:26:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Martin Simon 2013-10-03 12:49:44 UTC
Description of problem:
I'm unable to build inkscape using source data from src.rpm. We use it to execute upstream testsets (via `make check`).

There is an extra comma "," at the end of one line. In upstream I can see the extra character is removed correctly.

Version-Release number of selected component (if applicable):
inkscape-0.48.4-7.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. get src.rpm, extract sources and after configuring execute `make`

Actual results:
...
In file included from desktop.cpp:91:0:
widgets/desktop-widget.h:242:32: error: stray ‘,’ at end of member declaration
     GtkWidget *commands_toolbox,;
                                ^
...

Expected results:
inkscape should be built correctly

Additional info:

Comment 1 Jan Horak 2013-12-17 14:26:35 UTC
You should run tests on patched sources by doing 'rhpkg prep' or 'rpmbuild -bp' with srpm. Otherwise you're testing original sources and not sources which was actually used to build the package.

The wrong widgets/desktop-widget.h is in upstream tarball, see 
http://downloads.sourceforge.net/inkscape/inkscape-0.48.4.tar.gz if interested. However it is fixed in latest trunk, so . We have inkscape-0.48.4-spuriouscomma.h patch to fix this problem.