Bug 1015194

Summary: Storage node configuration UI shows stale values
Product: [Other] RHQ Project Reporter: John Sanda <jsanda>
Component: Core ServerAssignee: Jirka Kremser <jkremser>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.9CC: hrupp, jkremser
Target Milestone: ---   
Target Release: RHQ 4.10   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1018810 (view as bug list) Environment:
Last Closed: 2014-04-23 12:30:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 951619, 1018810    

Description John Sanda 2013-10-03 15:38:36 UTC 
Description of problem:
After updating the storage node configuration, the UI shows the old values from before the change. This is not a UI specific issue. The same behavior can be found in the CLI. The problem stems from how we perform the resource configuration change. It is being done as a resource operation and not as a configuration update (via ConfigurationManagerBean). The method StorageNodeManagerBean.retrieveConfiguration(Subject, StorageNode) returns the latest values in the database and those values become stale when the resource operation is executed because the change is only made on the physical resource and not updated in the database. 

I think that the config changes should be done as a resource config update. This has two benefits. First, it resolves this issue because the resource config update will update the actual resource as well as the value in the database. Secondly, we have an update trail of the config changes. By applying the change as a resource operation we do not have an easy way to see what past values of the storage node configuration look like.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. Go to storage node admin UI
2. Go to storage node details view
3. Change any of the configuration settings and click the Save button

Actual results:
The values prior to the change are displayed

Expected results:
The new values should be displayed

Additional info:
Comment 1 Jirka Kremser 2013-10-09 13:41:02 UTC 
branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=85be6cbf4
time:    2013-10-09 15:19:45 +0200
commit:  85be6cbf4f0945c0d8c13a05d06cbf329cb2f4c9
author:  Jirka Kremser - jkremser
message: [BZ 1015194] - Storage node configuration UI shows stale values - Using
         the resource config update instead of update done by resource
         operation.
Comment 2 Jirka Kremser 2013-10-14 12:42:04 UTC 
branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=10c67f692
time:    2013-10-14 14:40:33 +0200
commit:  10c67f692e3d08537cc4097bf3e4b11f75f4a5f6
author:  Jirka Kremser - jkremser
message: [BZ 1015194] - Storage node configuration UI shows stale values - The
         restart is now done in the SLSB layer using the resource
         operation instead of the agent side, because we don't want to
         let the common resource configuration updates to cause the
         restart of the storage node (the restart is done only for those
         config changes that was done using the admin UI).
Comment 3 Heiko W. Rupp 2014-04-23 12:30:04 UTC 
Bulk closing of 4.10 issues.

If an issue is not solved for you, please open a new BZ (or clone the existing one) with a version designator of 4.10.