Bug 1015865

Summary:	docker build fails due to missing LOOP_CTL_GET_FREE in EL version of linux/loop.h
Product:	[Fedora] Fedora EPEL	Reporter:	Lokesh Mandvekar <lsm5>
Component:	docker-io	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	el6	CC:	alexl, arozansk, jkeck, jpoimboe, lsm5, mattdm, mgoldman
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-10-08 04:14:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lokesh Mandvekar 2013-10-06 11:04:30 UTC

Description of problem: rpmbuild fails


Version-Release number of selected component (if applicable): 0.7-1.staging


How reproducible: Always


Steps to Reproduce:
1. run rpmbuild on docker-io spec file on EL6

Actual results:
# github.com/dotcloud/docker/devmapper
devmapper.go: In function 'attach_loop_device':
devmapper.go:29: error: 'LOOP_CTL_GET_FREE' undeclared (first use in this function)
devmapper.go:29: error: (Each undeclared identifier is reported only once
devmapper.go:29: error: for each function it appears in.)
error: Bad exit status from /var/tmp/rpm-tmp.iYm5vM (%build)


Additional info:

linux/loop.h in el6 doesn't seem to define LOOP_CTL_GET_FREE.

Comment 1 Aristeu Rozanski 2013-10-07 15:01:05 UTC

It looks like it's not only the definition missing, but on demand loop device
allocation.
upstream: 770fe30a46a12b6fb6b63fbe1737654d28e84844

Comment 2 Aristeu Rozanski 2013-10-07 15:05:15 UTC

(In reply to Aristeu Rozanski from comment #1)
> It looks like it's not only the definition missing, but on demand loop device
> allocation.
> upstream: 770fe30a46a12b6fb6b63fbe1737654d28e84844

I was told if the feature isn't available, docker will fall back to another
method. Please ignore my last comment.

Comment 3 Lokesh Mandvekar 2013-10-07 15:08:11 UTC

(In reply to Aristeu Rozanski from comment #2)
> I was told if the feature isn't available, docker will fall back to another
> method. Please ignore my last comment.

Thanks Aris. https://github.com/alexlarsson/docker/commit/323f3c2bc1566c5c66e4ba49f760030f2c5adae0 via Alex. Should be merged upstream soon.

Comment 4 Lokesh Mandvekar 2013-10-08 04:14:49 UTC

Merged in v0.7-rc2 upstream ... closing!