Bug 1015976

Starting with version 1.3 there are tests that fail on big endian platforms like ppc or s390 on both 32 and 64 bits

...
ok 345 - rrset: rdata_item_size
ok 346 - rrset: merge
ok 347 - rrset: merge no dupl
ok 348 - rrset: next dname
ok 349 - rrset: remove rr
ok 350 - rrset: find pos
# Testing unit: Wire
#   Failed test '16-bit write'
#   at libknot/wire_tests.c line 60.
#   Failed test '32-bit write'
#   at libknot/wire_tests.c line 76.
#   Failed test '48-bit read'
#   at libknot/wire_tests.c line 84.
#   Failed test '48-bit write'
#   at libknot/wire_tests.c line 93.
# Testing unit: dname
# Testing unit: zone tree
# Testing unit: libknot/sign
# Testing unit: libknot/rrset
# Looks like you failed 4 tests of 350 run.
FAIL: unittests


Version-Release number of selected component (if applicable):
knot-1.3.2-1.fc20

for full logs please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1225681 or http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1433479

Thank you for the report.

I do not have access to big endian hardware. Dan, please, can you point me how to submit scratch builds to s390/ppc koji? Do I need some additional permissions?

Jan

(In reply to Jan Včelák from comment #3)
> Thank you for the report.
> 
> I do not have access to big endian hardware. Dan, please, can you point me
> how to submit scratch builds to s390/ppc koji? Do I need some additional
> permissions?

the procedure is same as with scratch builds on primary, just use $(arch)-koji, where arch is s390 or ppc, for example "s390-koji build --scratch f20 knot-1.3-fixed.src.rpm"

(In reply to Dan Horák from comment #4)
> the procedure is same as with scratch builds on primary, just use
> $(arch)-koji, where arch is s390 or ppc, for example "s390-koji build
> --scratch f20 knot-1.3-fixed.src.rpm"

Perfect, thanks! I will take a look at it soon.

The problem was in unit tests, not in the wire format writing/reading code. Anyway, the test was completely rewritten because it was unnecessarily complicated.

Resolved in:
knot-1.3.2-2.fc19
knot-1.3.2-2.fc20
knot-1.3.2-2.fc21

knot-1.3.2-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/FEDORA-2013-18086/knot-1.3.2-2.fc19

knot-1.3.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/knot-1.3.2-2.fc20

I have submitted the builds into ppc and s390 as well. The build succeeds, but tagging od f20 build failed.

http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=200899 (f19 ppc)
http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=200897 (f20 ppc)
http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=200898 (f21 ppc)

https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1227651 (f19 s390)
https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1227653 (f20 s390)

(In reply to Jan Včelák from comment #9)
> I have submitted the builds into ppc and s390 as well. The build succeeds,
> but tagging od f20 build failed.
> 
> http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=200899 (f19 ppc)
> http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=200897 (f20 ppc)
> http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=200898 (f21 ppc)
> 
> https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1227651 (f19 s390)
> https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1227653 (f20 s390)

Thanks for the fast fix, Jan. There is no need to do builds on ppc or s390 (generally secondary arches), they are started automagically after a build finishes and is tagged in primary koji.

(In reply to Dan Horák from comment #10)
> Thanks for the fast fix, Jan. There is no need to do builds on ppc or s390
> (generally secondary arches), they are started automagically after a build
> finishes and is tagged in primary koji.

No problem. OK, I will keep it in mind for the next time.

Package knot-1.3.2-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing knot-1.3.2-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-18547/knot-1.3.2-2.fc20
then log in and leave karma (feedback).

knot-1.3.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

knot-1.3.2-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.